-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save 10seconds when running NetworkSpec #651
Conversation
Test Results266 tests - 11 260 ✔️ - 11 14m 4s ⏱️ -59s Results for commit 80ba588. ± Comparison against base commit 11b2b16. This pull request removes 11 tests.
♻️ This comment has been updated with latest results. |
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Cost of Init Transaction
Cost of Commit TransactionCurrently only one UTxO per commit allowed (this is about to change soon)
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
|
d966fda
to
ef2d634
Compare
withServerNode last param is a callabck called when the server is listening. We use it to control when we want to start connecting to other nodes. Because we are good citizen and start by listening to connection before trying to connect to peers ourselves.
By explicilitly waiting for the serverAsync we ensure that, in cas this thread crashes for any reason, we acknowledge it and stop our process.
cd327c8
to
80ba588
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top!
Depending on how the different Ouroboros servers are instantiated during the tests, the tests can take 0.3 seconds or 10.3 seconds. This is due to ipRetryDelay .
We add a threadDelay before trying to connect to other peer so that we give our own listen thread to be already listening... which seems fair.
To check before merging: