Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic in jormungandr logs after stake pool retiremenet #2147

Open
dkijania opened this issue Apr 27, 2020 · 2 comments
Open

Panic in jormungandr logs after stake pool retiremenet #2147

dkijania opened this issue Apr 27, 2020 · 2 comments
Labels
A-jormungandr Area: Issues affecting jörmungandr automated bug Something isn't working

Comments

@dkijania
Copy link
Contributor

Describe the bug
There is an ugly panic in jormungandr after stake pool (the only one in blockchain) was retired:

"thread \'tokio-runtime-worker\' panicked at \'Distribution of rewards will not overflow: Delegation(NotFound($ hash_ty(0x38d18bcafb8ba65673dc00eb8ce7150ea3a7e61c24153dafa23cb437caa9b970)))\', jormungandr/src/blockchain/chain.rs:852:46"

Mandatory Information

  1. jcli --full-version: newest master
  2. jormungandr --full-version newest master

To Reproduce
Steps to reproduce the behavior:

  1. start blockchain with single stake pool
  2. retire it after some time
  3. Observe issue

Expected behavior
node stats should be updated

Additional context
There is PR with automated test for this issue. #2145. Run test by:

 cd jormungandr-integration-tests
`cargo test test_pool_update`
@dkijania dkijania added bug Something isn't working A-jormungandr Area: Issues affecting jörmungandr automated labels Apr 27, 2020
@dkijania dkijania changed the title Panic in jormungandr after stake pool retiremenet Panic in jormungandr logs after stake pool retiremenet Apr 27, 2020
@dkijania
Copy link
Contributor Author

dkijania commented Jun 7, 2020

Panic is produced when we retire the only one stake pool in blockchain. Therefore it's only matter or better error reporting

This was referenced Dec 10, 2020
Closed
Closed
@eugene-babichenko eugene-babichenko mentioned this issue Dec 12, 2020
Merged
@mzabaluev
Copy link
Contributor

Is this reproducible after #2815?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-jormungandr Area: Issues affecting jörmungandr automated bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mzabaluev @dkijania