Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockfetch can get stuck fetching data from a slow peer #2430

Closed
karknu opened this issue Jul 17, 2020 · 0 comments
Closed

Blockfetch can get stuck fetching data from a slow peer #2430

karknu opened this issue Jul 17, 2020 · 0 comments

Comments

@karknu
Copy link
Contributor

karknu commented Jul 17, 2020

There is a problem where Blockfetch will get stuck fetching data from a far-away peer.
The number of peers we’re fetching data from is controlled by MaxConcurrencyBulkSync, which is set to 1.
If a node starts to use a slow peer (for example because it was listed first in the topology file) it will never move away from it. Any possible requests from new peers will be stomped by MaxConcurrencyBulkSync , even if they could complete faster based on deltaQ estimates.
The only way we switch peers if there is enough network disruption that the outstanding request queue completely drain.

@coot coot added this to the S18 2020-07-30 milestone Jul 20, 2020
iohk-bors bot added a commit that referenced this issue Jul 21, 2020
2441: Blockfetch improvements needed before KeepAlive client can be enabled. r=karknu a=karknu

Fixes #2434 #2433 and #2430 which are required for #1416.

Co-authored-by: Karl Knutsson <[email protected]>
@karknu karknu closed this as completed Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants