Concurrently combinator & Handler in MonadCatch #2298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In second patch I simplified |
Merged
dcoutts
requested changes
Jun 25, 2020
dcoutts
approved these changes
Jun 25, 2020
|
Yes, and the branch name too :D; I'll clean the commits, |
Remove `HandlerM` from `MonadCatch` class and provide use `Handler` directly, without `mkHandler`.
coot
changed the title
|
bors merge |
jasagredo
added a commit
that referenced
this pull request
May 24, 2021
As by cardano-ledger-specs' PR #2298, the code that was isolated previously is being moved to the ledger side. This commit updates the ledger-spec dependency commit to the head of that branch and removes the relevant code. Co-authored-by: EncodePanda <[email protected]>
jasagredo
added a commit
that referenced
this pull request
May 24, 2021
As by cardano-ledger-specs' PR #2298, the code that was isolated previously is being moved to the ledger side. This commit updates the ledger-spec dependency commit to the head of that branch and removes the relevant code. Co-authored-by: EncodePanda <[email protected]>
jasagredo
added a commit
that referenced
this pull request
May 24, 2021
As by cardano-ledger-specs' PR #2298, the code that was isolated previously is being moved to the ledger side. This commit updates the ledger-spec dependency commit to the head of that branch and removes the relevant code. Co-authored-by: EncodePanda <[email protected]>
jasagredo
added a commit
that referenced
this pull request
May 25, 2021
As by cardano-ledger-specs' PR #2298, the code that was isolated previously is being moved to the ledger side. This commit updates the ledger-spec dependency commit to the head of that branch and removes the relevant code. Co-authored-by: EncodePanda <[email protected]>
jasagredo
added a commit
that referenced
this pull request
May 25, 2021
As by cardano-ledger-specs' PR #2298, the code that was isolated previously is being moved to the ledger side. This commit updates the ledger-spec dependency commit to the head of that branch and removes the relevant code. Co-authored-by: EncodePanda <[email protected]>
iohk-bors bot
added a commit
that referenced
this pull request
May 26, 2021
3177: Remove ShelleyLedgerExamples and update cardano-ledger-specs r=Jasagredo a=Jasagredo As by [cardano-ledger-specs' PR #2298](IntersectMBO/cardano-ledger#2298), the code that was isolated previously is being moved to the ledger side. This PR updates the ledger-spec dependency commit to the head of that branch and removes the relevant code. As a side change, `StandardCrypto` was defined in `Ouroboros.Consensus.Shelley.Protocol.Crypto` as well as in `Cardano.Ledger.Crypto`, with the same verbatim declaration. Now that we generate data on ledger's side we are using their `StandardCrypto` definition which is incompatible with ours, so in order to fix type errors, our definition was removed in favor of theirs. This shouldn't mean any real change because as stated in their code (see the comment removed in their [PR#2298](IntersectMBO/cardano-ledger#2298), both definitions MUST have been (and remain) equal at all times. Note that the two first commits are related to this PR and the last one updates ledger-specs and plutus to the correct commits, and fixes imports. This addresses #3139 Co-authored-by: Javier Sagredo <[email protected]>
coot
added a commit
that referenced
this pull request
May 16, 2022
2298: Concurrently combinator & Handler in MonadCatch r=coot a=coot `ConcurentlyM`, like `Concurently` but for `MonadAsync`. It's not part of the `MonadAsync` which makes it simpler to implement and use, but we're not reusing `Concurrently` for `MonadAsync`'s `IO` instance. Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConcurentlyM, likeConcurentlybut forMonadAsync. It's not part of theMonadAsyncwhich makes it simpler to implement and use, but we're not reusingConcurrentlyforMonadAsync'sIOinstance.