Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2^6 KES periods rather than 2^7 #2403

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Use 2^6 KES periods rather than 2^7 #2403

merged 1 commit into from
Jul 14, 2020

Conversation

dcoutts
Copy link
Contributor

@dcoutts dcoutts commented Jul 14, 2020

So instead of 24hr KES periods we will use 36hr ones, and still get 90
days within 64 periods. This makes better use of the space than 128
periods of 24hrs that we chop off at 90 days.

It also brings the header size to under 1kb.

So instead of 24hr KES periods we will use 36hr ones, and still get 90
days within 64 periods. This makes better use of the space than 128
periods of 24hrs that we chop off at 90 days.

It also brings the header size to under 1kb.
@dcoutts dcoutts requested review from mrBliss and nc6 July 14, 2020 14:59
@mrBliss
Copy link
Contributor

mrBliss commented Jul 14, 2020

I expect this will break the golden tests. To update them: delete the test/golden folder in ouroboros-consensus-shelley-test and ouroboros-consensus-cardano and rerun the respective testsuites (-p Golden to just run the golden tests).

@mrBliss
Copy link
Contributor

mrBliss commented Jul 14, 2020

I expect this will break the golden tests. To update them: delete the test/golden folder in ouroboros-consensus-shelley-test and ouroboros-consensus-cardano and rerun the respective testsuites (-p Golden to just run the golden tests).

UPDATE: ah, I'm mistaken, we run the golden tests with mock crypto (because we're reusing the examples from cardano-ledger-specs, which use mock crypto), so changing the KES algorithm of the real crypto won't affect the golden tests.

@dcoutts
Copy link
Contributor Author

dcoutts commented Jul 14, 2020

bors merge

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jul 14, 2020

@iohk-bors iohk-bors bot merged commit 0e994c3 into master Jul 14, 2020
@iohk-bors iohk-bors bot deleted the dcoutts/kes-sum6 branch July 14, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants