Blockfetch improvements needed before KeepAlive client can be enabled. #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karknu
force-pushed
the
karknu/blockfetch_imp
branch
from
bec9f03 to
9a81995
Compare
coot
reviewed
Jul 20, 2020
coot
reviewed
Jul 20, 2020
karknu
force-pushed
the
karknu/blockfetch_imp
branch
from
9a81995 to
7ca3a39
Compare
coot
reviewed
Jul 20, 2020
karknu
force-pushed
the
karknu/blockfetch_imp
branch
from
7a91175 to
13e8580
Compare
coot
reviewed
Jul 21, 2020
ouroboros-network/test/Ouroboros/Network/BlockFetch/Examples.hs
Outdated
Show resolved
Hide resolved
nfrisby
reviewed
Jul 21, 2020
nfrisby
reviewed
Jul 21, 2020
ouroboros-consensus/ouroboros-consensus-test-infra/src/Test/ThreadNet/Network.hs
Show resolved
Hide resolved
karknu
force-pushed
the
karknu/blockfetch_imp
branch
from
13e8580 to
76f1297
Compare
Enforce a min low watermark to ensure that blockfetch can do pipelining.
Constantly re-evaluating the the blockfetch descision logic is expensive. Limit it to 100Hz.
Implement smooth switching from slower to faster peers by temporarily ignoring the concurrency limit for faster peers. This lets faster peers starve out slower peers and makes it possible to switch peers without first having to wait for all outstanding requests to the slower peers to finish.
karknu
force-pushed
the
karknu/blockfetch_imp
branch
from
76f1297 to
a097f80
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2434 #2433 and #2430 which are required for #1416.