You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
I was reading through the project, and noticed there were multiple sets of classes which behave (and are used) as if they were subclasses of some base class, without actually being one.
Specifically: microscopes, experiments, and cameras.
Is there a reason for this? If not, I started implementing some basic base classes for these in https://github.com/viljarjf/instamatic/tree/add-inheritance.
This would help with #89 I think, by making the necessary implementation steps easier (you would just need to make a new subclass and implement the abstract members)
It should also help a little with testing, provided the subclasses are not too difficult to instantiate,(see e.g. https://github.com/viljarjf/instamatic/blob/add-inheritance/tests/test_experiments.py)
The text was updated successfully, but these errors were encountered:
Hello,
I was reading through the project, and noticed there were multiple sets of classes which behave (and are used) as if they were subclasses of some base class, without actually being one.
Specifically: microscopes, experiments, and cameras.
Is there a reason for this? If not, I started implementing some basic base classes for these in https://github.com/viljarjf/instamatic/tree/add-inheritance.
This would help with #89 I think, by making the necessary implementation steps easier (you would just need to make a new subclass and implement the abstract members)
It should also help a little with testing, provided the subclasses are not too difficult to instantiate,(see e.g. https://github.com/viljarjf/instamatic/blob/add-inheritance/tests/test_experiments.py)
The text was updated successfully, but these errors were encountered: