Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base classes for microscope, camera, experiment ect. #90

Closed
viljarjf opened this issue Oct 11, 2024 · 2 comments
Closed

Base classes for microscope, camera, experiment ect. #90

viljarjf opened this issue Oct 11, 2024 · 2 comments

Comments

@viljarjf
Copy link
Contributor

viljarjf commented Oct 11, 2024

Hello,
I was reading through the project, and noticed there were multiple sets of classes which behave (and are used) as if they were subclasses of some base class, without actually being one.
Specifically: microscopes, experiments, and cameras.
Is there a reason for this? If not, I started implementing some basic base classes for these in https://github.com/viljarjf/instamatic/tree/add-inheritance.
This would help with #89 I think, by making the necessary implementation steps easier (you would just need to make a new subclass and implement the abstract members)
It should also help a little with testing, provided the subclasses are not too difficult to instantiate,(see e.g. https://github.com/viljarjf/instamatic/blob/add-inheritance/tests/test_experiments.py)

@stefsmeets
Copy link
Member

Hi @viljarjf , you are right that this would be useful.

The reason for it is lack of skills on my side when I wrote these classes :-)

If you are willing to contribute your code, I would be happy to take a PR on this. Especially better and more complete tests are very welcome.

@stefsmeets
Copy link
Member

Closed by #91

Thanks for contributing this @viljarjf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants