Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover "tail" doesn't appear #148

Closed
connercms opened this issue Feb 21, 2019 · 3 comments
Closed

Popover "tail" doesn't appear #148

connercms opened this issue Feb 21, 2019 · 3 comments

Comments

@connercms
Copy link

Using RN v0.57.1 and rnpm v0.14.2, I am unable to make the popup renderer "tail" appear, no matter what I configure with rendererProps. It simply appears as a box.

The following code taken directly from the example (with the exception of custom MenuTrigger child)

<Menu renderer={renderers.Popover} rendererProps={{placement: 'bottom'}}>
    <MenuTrigger>
        <MaterialCommunityIcons name="filter" size={30} />
    </MenuTrigger>
    <MenuOptions>
        <MenuOption onSelect={() => alert(`Save`)} text="Save" />
        <MenuOption onSelect={() => alert(`Delete`)}>
          <Text style={{color: 'red'}}>Delete</Text>
        </MenuOption>
        <MenuOption onSelect={() => alert(`Not called`)} disabled={true} text="Disabled" />
    </MenuOptions>
</Menu>

Produces the following

screen shot 2019-02-21 at 11 31 49 am

@connercms
Copy link
Author

After looking through the library code, I discovered the default anchor style background color is set to white, so it won't show against white backgrounds. Might add this to the docs somewhere as it wasn't clear. For anyone with a similar issue, to configure the anchor colors, add anchorStyle inside the rendererProps

<Menu renderer={renderers.Popover} 
rendererProps={{placement: 'bottom', anchorStyle: {backgroundColor: '#eaeaea'}}}>

@IgorVanian
Copy link

@connercms So why the shadow isn't applied to the anchor? In the library the elevation is applied but not iOS shadow props.

@sodik82
Copy link
Contributor

sodik82 commented Apr 12, 2019

PR welcomed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants