Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

fix(pinecone): fix issue that pinecone's icon padding is too big #127

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

EiffelFly
Copy link
Member

Because

  • The pinecone's icon padding is too big, which cause the icon look far smaller than other icon, this PR update the icon

This commit

  • fix issue that pinecone's icon padding is too big

@EiffelFly EiffelFly changed the title fix: fix issue that pinecone's icon padding is too big fix(pinecone): fix issue that pinecone's icon padding is too big Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa391c0) 62.18% compared to head (540b6fc) 62.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   62.18%   62.18%           
=======================================
  Files          18       18           
  Lines        1489     1489           
=======================================
  Hits          926      926           
  Misses        440      440           
  Partials      123      123           
Flag Coverage Δ
unittests 62.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@donch1989 donch1989 merged commit d27697e into main Feb 16, 2024
12 checks passed
@donch1989 donch1989 deleted the update-pinecone-icon branch February 16, 2024 03:59
donch1989 pushed a commit that referenced this pull request Feb 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.12.0-beta](v0.11.0-beta...v0.12.0-beta)
(2024-02-16)


### Features

* **restapi:** use `instillFormat: semi-structured/json` for request and
response body
([#126](#126))
([53606c1](53606c1))
* set component versions to 0.1.0-alpha
([#123](#123))
([81af1d5](81af1d5))
* store icons next to the component definition
([#122](#122))
([c67fc89](c67fc89))


### Bug Fixes

* **instill:** fix auth issue
([#128](#128))
([9908b3a](9908b3a))
* **pinecone:** fix issue that pinecone's icon padding is too big
([#127](#127))
([d27697e](d27697e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants