From 821dab3768dad53f1c4e49ac786e758643825eb3 Mon Sep 17 00:00:00 2001 From: phelan_instill Date: Wed, 14 Sep 2022 21:53:58 +0700 Subject: [PATCH] fix: update description for GitHub model from user input (#173) Because - description should come from a single source (user input) This commit - update description for GitHub model from user input parameter --- pkg/handler/handler.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkg/handler/handler.go b/pkg/handler/handler.go index 3704deeb..fcd1bcd1 100644 --- a/pkg/handler/handler.go +++ b/pkg/handler/handler.go @@ -71,8 +71,8 @@ func NewHandler(s service.Service, t triton.Triton) modelPB.ModelServiceServer { } } -//writeToFp takes in a file pointer and byte array and writes the byte array into the file -//returns error if pointer is nil or error in writing to file +// writeToFp takes in a file pointer and byte array and writes the byte array into the file +// returns error if pointer is nil or error in writing to file func writeToFp(fp *os.File, data []byte) error { w := 0 n := len(data) @@ -896,12 +896,16 @@ func createGitHubModel(h *handler, ctx context.Context, req *modelPB.CreateModel Repository: modelConfig.Repository, HtmlUrl: "https://github.com/" + modelConfig.Repository, }) + description := "" + if req.Model.Description != nil { + description = *req.Model.Description + } githubModel := datamodel.Model{ ID: req.Model.Id, ModelDefinitionUid: modelDefinition.UID, Owner: owner, Visibility: datamodel.ModelVisibility(visibility), - Description: githubInfo.Description, + Description: description, Configuration: bModelConfig, Instances: []datamodel.ModelInstance{}, }