Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): fix db connection bug #279

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

pinglin
Copy link
Member

@pinglin pinglin commented Oct 21, 2023

Because

  • migration processes were using a shared db connection causing the very first migration process early closing the db connection resulting the subsequent migration processes failed to connect the db.
  • this issue wasn't obvious in a docker compose up scenario because the restart policy restart: on-failure simply has the pipeline-backend-migration container re-launched several time until all migration processes are finished.

This commit

  • make the migration processes using non-shared db connection

@pinglin pinglin merged commit 028a093 into main Oct 21, 2023
@pinglin pinglin deleted the pinglin/fix-migration-db-connection branch October 21, 2023 23:38
donch1989 pushed a commit that referenced this pull request Oct 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.16.1-alpha](v0.16.0-alpha...v0.16.1-alpha)
(2023-10-27)


### Bug Fixes

* **migration:** fix db connection bug
([#279](#279))
([028a093](028a093))
* **service:** fix basic view should return null recipe
([#281](#281))
([5d0367c](5d0367c))


### Miscellaneous Chores

* **release:** release v0.16.1-alpha
([272eae9](272eae9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Oct 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.16.1-alpha](v0.16.0-alpha...v0.16.1-alpha)
(2023-10-27)


### Bug Fixes

* **migration:** fix db connection bug
([#279](#279))
([028a093](028a093))
* **service:** fix basic view should return null recipe
([#281](#281))
([5d0367c](5d0367c))


### Miscellaneous Chores

* **release:** release v0.16.1-alpha
([272eae9](272eae9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Oct 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.16.1-alpha](v0.16.0-alpha...v0.16.1-alpha)
(2023-10-27)


### Bug Fixes

* **migration:** fix db connection bug
([#279](#279))
([028a093](028a093))
* **service:** fix basic view should return null recipe
([#281](#281))
([5d0367c](5d0367c))


### Miscellaneous Chores

* **release:** release v0.16.1-alpha
([8552d59](8552d59))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants