Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: calculate the trigger_count with batch_size #338

Merged
merged 1 commit into from
Dec 20, 2023
Merged

fix: calculate the trigger_count with batch_size #338

merged 1 commit into from
Dec 20, 2023

Conversation

donch1989
Copy link
Member

Because

  • we need to use the batch_size to increment the trigger_count

This commit

  • calculate the trigger_count with batch_size

@linear Linear
Copy link

linear bot commented Dec 20, 2023

INS-2968 the batch trigger should be counted properly

@codecov Codecov
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (6e282eb) 0.65% compared to head (335dff8) 0.64%.

Files Patch % Lines
pkg/service/service.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##            main    #338      +/-   ##
========================================
- Coverage   0.65%   0.64%   -0.01%     
========================================
  Files         10      10              
  Lines       3230    3234       +4     
========================================
  Hits          21      21              
- Misses      3209    3213       +4
Flag Coverage Δ
unittests 0.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit 423e6c9 into main Dec 20, 2023
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-2968 branch December 20, 2023 02:35
@droplet-bot droplet-bot mentioned this pull request Dec 19, 2023
Merged
donch1989 pushed a commit that referenced this pull request Dec 20, 2023
@droplet-bot
chore(main): release 0.18.1-beta (#337)
c19579b 
🤖 I have created a release *beep* *boop*
---


##
[0.18.1-beta](v0.18.0-beta...v0.18.1-beta)
(2023-12-20)


### Features

* Improve error messages in connector execution
([#311](#311))
([6e282eb](6e282eb))


### Bug Fixes

* calculate the trigger_count with batch_size
([#338](#338))
([423e6c9](423e6c9))


### Miscellaneous Chores

* release v0.18.1-beta
([e5d5603](e5d5603))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@donch1989 donch1989 mentioned this pull request Dec 20, 2023
Merged
donch1989 pushed a commit to instill-ai/instill-core that referenced this pull request Dec 20, 2023
@droplet-bot
chore(main): release 0.19.1-beta (#409)
bf9f8a5 
🤖 I have created a release *beep* *boop*
---


##
[0.19.1-beta](v0.19.0-beta...v0.19.1-beta)
(2023-12-20)

### Bug Fixes

* calculate the trigger_count with batch_size
(instill-ai/pipeline-backend#338)
([423e6c9](instill-ai/pipeline-backend@423e6c9))

### Miscellaneous Chores

* release v0.19.1-beta
([3e6804c](3e6804c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@donch1989 donch1989 mentioned this pull request Dec 20, 2023
Merged
donch1989 pushed a commit to instill-ai/instill-core that referenced this pull request Dec 20, 2023
@droplet-bot
chore(main): release 0.19.1-beta (#410)
8a9afa0 
🤖 I have created a release *beep* *boop*
---


##
[0.19.1-beta](v0.19.0-beta...v0.19.1-beta)
(2023-12-20)

### Bug Fixes

* calculate the trigger_count with batch_size
(instill-ai/pipeline-backend#338)
([423e6c9](instill-ai/pipeline-backend@423e6c9))

### Miscellaneous Chores

* release v0.19.1-beta
([cc4998c](cc4998c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Dec 20, 2023
Merged
donch1989 pushed a commit that referenced this pull request Dec 20, 2023
@droplet-bot
chore(main): release 0.18.1-beta (#339)
9414eb3 
🤖 I have created a release *beep* *boop*
---


##
[0.18.1-beta](v0.18.0-beta...v0.18.1-beta)
(2023-12-20)


### Features

* Improve error messages in connector execution
([#311](#311))
([6e282eb](6e282eb))


### Bug Fixes

* calculate the trigger_count with batch_size
([#338](#338))
([423e6c9](423e6c9))


### Miscellaneous Chores

* release v0.18.1-beta
([9892d8a](9892d8a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Dec 22, 2023
Merged
donch1989 pushed a commit that referenced this pull request Dec 22, 2023
@droplet-bot
chore(main): release 0.18.1-beta (#341)
5f3df1c 
🤖 I have created a release *beep* *boop*
---


##
[0.18.1-beta](v0.18.0-beta...v0.18.1-beta)
(2023-12-22)


### Features

* Improve error messages in connector execution
([#311](#311))
([6e282eb](6e282eb))


### Bug Fixes

* calculate the trigger_count with batch_size
([#338](#338))
([423e6c9](423e6c9))
* fix pipeline can not generate correct output schema
([#342](#342))
([502f1c4](502f1c4))


### Miscellaneous Chores

* release v0.18.1-beta
([df4ce1a](df4ce1a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Dec 25, 2023
Merged
donch1989 pushed a commit that referenced this pull request Dec 25, 2023
@droplet-bot
chore(main): release 0.18.1-beta (#345)
27936f7 
🤖 I have created a release *beep* *boop*
---


##
[0.18.1-beta](v0.18.0-beta...v0.18.1-beta)
(2023-12-25)


### Features

* Improve error messages in connector execution
([#311](#311))
([6e282eb](6e282eb))
* adjust pricing model


### Bug Fixes

* calculate the trigger_count with batch_size
([#338](#338))
([423e6c9](423e6c9))
* fix pipeline can not generate correct output schema
([#342](#342))
([502f1c4](502f1c4))


### Miscellaneous Chores

* release v0.18.1-beta
([6deb019](6deb019))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Dec 25, 2023
Closed
Closed
Merged
donch1989 pushed a commit that referenced this pull request Dec 25, 2023
@droplet-bot
chore(main): release 0.18.1-beta (#348)
c3beaae 
🤖 I have created a release *beep* *boop*
---


##
[0.18.1-beta](v0.18.0-beta...v0.18.1-beta)
(2023-12-25)


### Features

* Improve error messages in connector execution
([#311](#311))
([6e282eb](6e282eb))
* update pricing model


### Bug Fixes

* calculate the trigger_count with batch_size
([#338](#338))
([423e6c9](423e6c9))
* fix pipeline can not generate correct output schema
([#342](#342))
([502f1c4](502f1c4))


### Miscellaneous Chores

* release v0.18.1-beta
([6deb019](6deb019))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Apr 8, 2024
Closed
@droplet-bot droplet-bot mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin Awaiting requested review from pinglin

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

Assignees
No one assigned
Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donch1989 @droplet-bot