Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the wrong Temporal workflow retry setting #351

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Dec 29, 2023

Because

  • We only need retry for component execution, which is served by Temporal Activity. The Workflow retry is not needed since the recipe is the same, if it fail, it should fail forever.

This commit

  • fix the wrong Temporal workflow retry setting

Copy link

linear bot commented Dec 29, 2023

Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9bfe43c) 0.67% compared to head (0538a24) 0.67%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #351   +/-   ##
=====================================
  Coverage   0.67%   0.67%           
=====================================
  Files         10      10           
  Lines       3110    3110           
=====================================
  Hits          21      21           
  Misses      3089    3089           
Flag Coverage Δ
unittests 0.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit c3b71fc into main Dec 29, 2023
13 checks passed
@donch1989 donch1989 deleted the huitang/ins-3111 branch December 29, 2023 04:54
donch1989 pushed a commit that referenced this pull request Jan 2, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.19.0-beta](v0.18.1-beta...v0.19.0-beta)
(2024-01-02)


### Bug Fixes

* fix the wrong Temporal workflow retry setting
([#351](#351))
([c3b71fc](c3b71fc))
* force the connector and pipeline belong to same namespace
([#353](#353))
([7bbed56](7bbed56))
* remove unnecessary mgmt-backend request
([#349](#349))
([9bfe43c](9bfe43c))


### Miscellaneous Chores

* release v0.19.0-beta
([6ffa11c](6ffa11c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants