feat: remove ${[ ]} operator in component reference syntax
#383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donch1989
requested review from
pinglin,
xiaofei-du and
jvallesm
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
=====================================
Coverage 0.69% 0.69%
=====================================
Files 8 8
Lines 3033 3003 -30
=====================================
Hits 21 21
+ Misses 3012 2982 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donch1989
pushed a commit
that referenced
this pull request
Feb 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.22.0-beta](v0.21.1-beta...v0.22.0-beta) (2024-02-16) ### Features * add end-user errors on CreateExecution error ([#380](#380)) ([093c11c](093c11c)) * allow the string data to reference all data types that can be stringified ([#381](#381)) ([9342d23](9342d23)) * remove `${[ ]}` operator in component reference syntax ([#383](#383)) ([c121da8](c121da8)) ### Bug Fixes * fix reference bug ([#388](#388)) ([968c0ec](968c0ec)) * **worker:** fix temporal cloud namespace init ([#387](#387)) ([e42cf13](e42cf13)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
${[comp.xxx, comp.yyy]}operation to construct an array. However, it was not very straightforward, and we want to keep the syntax as pure as possible, retaining only the variable index ability. Additionally, we plan to use the JSON operator for array construction in the future.This commit
${[comp.xxx, comp.yyy]}operation from the component reference syntax.