Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor JSON Schema #48

Merged
merged 2 commits into from
May 6, 2022
Merged

fix: refactor JSON Schema #48

merged 2 commits into from
May 6, 2022

Conversation

xiaofei-du
Copy link
Member

Because

  • we want to provide JSON schema to all user-facing VDP resources

This commit

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #48 (778a184) into main (32cfc3f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      instill-ai/community#112   +/-   ##
=======================================
  Coverage   16.25%   16.25%           
=======================================
  Files           1        1           
  Lines         160      160           
=======================================
  Hits           26       26           
  Misses        126      126           
  Partials        8        8           
Flag Coverage Δ
unittests 16.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32cfc3f...778a184. Read the comment docs.

@xiaofei-du xiaofei-du force-pushed the fix-json-schema branch 2 times, most recently from a7c3c69 to 81d5fc0 Compare May 6, 2022 08:15
pinglin and others added 2 commits May 6, 2022 11:06
- adopt the latest proto
- add UI properties
Copy link
Member

@pinglin pinglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants