-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run): add requester id in list pipeline run response #770
Merged
joremysh
merged 1 commit into
main
from
jeremy/ins-6649-expose-requester-id-in-list-run-response
Oct 23, 2024
Merged
feat(run): add requester id in list pipeline run response #770
joremysh
merged 1 commit into
main
from
jeremy/ins-6649-expose-requester-id-in-list-run-response
Oct 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joremysh
requested review from
donch1989,
jvallesm and
chuang8511
as code owners
October 23, 2024 02:56
joremysh
force-pushed
the
jeremy/ins-6649-expose-requester-id-in-list-run-response
branch
from
October 23, 2024 06:10
2f26a52
to
147ee56
Compare
jvallesm
approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No blocking comments, I added some notes on improving clarity in the code.
joremysh
deleted the
jeremy/ins-6649-expose-requester-id-in-list-run-response
branch
October 23, 2024 08:06
donch1989
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.45.0-beta](v0.44.0-beta...v0.45.0-beta) (2024-10-23) ### Features * **run:** add requester id in list pipeline run response ([#770](#770)) ([a89a03d](a89a03d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
jvallesm
pushed a commit
that referenced
this pull request
Oct 29, 2024
Because - console runs page needs to display requester This commit - expose requester id in pipeline runs response ![image](https://github.com/user-attachments/assets/6fda4afb-62ba-41dc-9238-248172abba54)
jvallesm
pushed a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.45.0-beta](v0.44.0-beta...v0.45.0-beta) (2024-10-23) ### Features * **run:** add requester id in list pipeline run response ([#770](#770)) ([a89a03d](a89a03d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
donch1989
pushed a commit
that referenced
this pull request
Nov 1, 2024
Because - pipeline run data column names should be more straightforward and aligned with model, following discussions here: #770 (comment) This commit - modify column names, struct field names and fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit