Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(run): add requester id in list pipeline run response #770

Merged

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 23, 2024

Because

  • console runs page needs to display requester

This commit

  • expose requester id in pipeline runs response

image

Copy link

linear bot commented Oct 23, 2024

@joremysh joremysh force-pushed the jeremy/ins-6649-expose-requester-id-in-list-run-response branch from 2f26a52 to 147ee56 Compare October 23, 2024 06:10
Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking comments, I added some notes on improving clarity in the code.

pkg/service/pipelinerun.go Show resolved Hide resolved
pkg/service/pipelinerun.go Show resolved Hide resolved
pkg/service/pipelinerun.go Show resolved Hide resolved
@joremysh joremysh merged commit a89a03d into main Oct 23, 2024
12 checks passed
@joremysh joremysh deleted the jeremy/ins-6649-expose-requester-id-in-list-run-response branch October 23, 2024 08:06
donch1989 pushed a commit that referenced this pull request Oct 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.45.0-beta](v0.44.0-beta...v0.45.0-beta)
(2024-10-23)


### Features

* **run:** add requester id in list pipeline run response
([#770](#770))
([a89a03d](a89a03d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
Because

- console runs page needs to display requester

This commit

- expose requester id in pipeline runs response


![image](https://github.com/user-attachments/assets/6fda4afb-62ba-41dc-9238-248172abba54)
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.45.0-beta](v0.44.0-beta...v0.45.0-beta)
(2024-10-23)


### Features

* **run:** add requester id in list pipeline run response
([#770](#770))
([a89a03d](a89a03d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Nov 1, 2024
Because

- pipeline run data column names should be more straightforward and
aligned with model, following discussions here:
#770 (comment)

This commit

- modify column names, struct field names and fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants