fix: fix pipeline trigger model hanging #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 16.75% // Head: 16.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main instill-ai/pipeline-backend#80 +/- ##
==========================================
- Coverage 16.75% 16.21% -0.54%
==========================================
Files 4 4
Lines 752 777 +25
==========================================
Hits 126 126
- Misses 604 629 +25
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pinglin
requested changes
Oct 23, 2022
pkg/service/service.go
Outdated
| }() | ||
| for err := range errors { | ||
| if err != nil { | ||
| logger.Error(fmt.Sprintf("[connector-backend] Error trigger model instance got error %v", err.Error())) |
There was a problem hiding this comment.
Suggested change
| logger.Error(fmt.Sprintf("[connector-backend] Error trigger model instance got error %v", err.Error())) | |
| logger.Error(fmt.Sprintf("[model-backend] Error trigger model instance got error %v", err.Error())) |
pinglin
approved these changes
Oct 23, 2022
pinglin
changed the title
pinglin
pushed a commit
that referenced
this pull request
Oct 25, 2022
Because - Trigger model timeout 5 seconds is not enough for making model inference - Goroutines use sync.WaitGroup which does not decrease the counter due to exception errors This commit - Increase timeout to 30 seconds - defer wg.Done() and end function when have any error - close #79 - close #77
xiaofei-du
pushed a commit
to instill-ai/instill-core
that referenced
this pull request
Dec 25, 2022
🤖 I have created a release *beep* *boop* --- ## Product Updates ### Announcement 📣 * VDP is officially renamed to `Versatile Data Pipeline`. We realise that as a general ETL infrastructure, VDP is capable of processing all kinds of unstructured data, and we should not limit its usage to only visual data. That's why we replace the word Visual with Versatile. Besides, the term Data Preparation is a bit misleading, users often think it has something to do with data labelling or cleaning. The term Data Pipeline is definitely more precise to capture the core concept of VDP. ### Features ✨ * support new task Instance segmentation. Check out the [Streamlit example](https://github.com/instill-ai/vdp/tree/main/examples/streamlit/instance_segmentation) ## VDP ([0.3.0-alpha](v0.2.6-alpha...v0.3.0-alpha)) ### Features * support Instance segmentation task [0476f59](0476f59) * add console e2e test into vdp ([#148](#148)) ([a779a11](a779a11)) * add instance segmentation example ([#167](https://github.com/instill-ai/vdp/pull/167))([c341e0c](https://github.com/instill-ai/vdp/commit/c341e0cf4c48a181ca7cb0e76acf512f4e4b46c7)) ### Bug Fixes * fix wrong triton environment when deploying HuggingFace models ([#150](#150)) ([b2fda36](b2fda36)) * use COCO RLE format for instance segmentation ([4d10e46](4d10e46)) * update model output protocol ([e6ea88d](e6ea88d)) ## Pipeline-backend ([0.9.3-alpha](https://github.com/instill-ai/pipeline-backend/releases/tag/v0.9.3-alpha)) ### Bug Fixes * fix pipeline trigger model hanging (instill-ai/pipeline-backend#80) ([7ba58e5](instill-ai/pipeline-backend@7ba58e5)) ## Connector-backend ([0.7.2-alpha](https://github.com/instill-ai/connector-backend/releases/tag/v0.7.2-alpha)) ### Bug Fixes * fix connector empty description update ([0bc3086](instill-ai/connector-backend@0bc3086)) ## Model-backend ([0.10.0-alpha](https://github.com/instill-ai/model-backend/releases/tag/v0.10.0-alpha)) ### Features * support instance segmentation task (instill-ai/model-backend#183) ([d28cfdc](instill-ai/model-backend@d28cfdc)) * support async deploy and undeploy model instance (instill-ai/model-backend#192) ([ed36dc7](instill-ai/model-backend@ed36dc7)) * support semantic segmentation (instill-ai/model-backend#203) ([f22262c](instill-ai/model-backend@f22262c)) ### Bug Fixes * allow updating emtpy description for a model (instill-ai/model-backend#177) ([100ec84](instill-ai/model-backend@100ec84)) * HuggingFace batching bug in preprocess model ([b1582e8](instill-ai/model-backend@b1582e8)) * model instance state update to unspecified state (instill-ai/model-backend#206) ([14c87d5](instill-ai/model-backend@14c87d5)) * panic error with nil object (instill-ai/model-backend#208) ([a342113](instill-ai/model-backend@a342113)) ## Console ### Features * extend the time span of our user cookie (instill-ai/console#289) ([76a6f99](instill-ai/console@76a6f99)) * finish integration test and make it stable (instill-ai/console#281) ([3fd8d21](instill-ai/console@3fd8d21)) * replace prism.js with code-hike (instill-ai/console#292) ([cb61708](instill-ai/console@cb61708)) * unify the gap between elements in every table (instill-ai/console#291) ([e743820](instill-ai/console@e743820)) * update console request URL according to new protobuf (instill-ai/console#287) ([fa7ecc3](instill-ai/console@fa7ecc3)) * add hg model id field at model_instance page (instill-ai/console#300) ([31a6eab](instill-ai/console@31a6eab)) * cleanup connector after test (instill-ai/console#295) ([f9c8e4c](instill-ai/console@f9c8e4c)) * disable html report (instill-ai/console#297) ([689f50d](instill-ai/console@689f50d)) * enhance the warning of the resource id field (instill-ai/console#303) ([6c4aa4f](instill-ai/console@6c4aa4f)) * make playwright output dot on CI (instill-ai/console#293) ([e5c2958](instill-ai/console@e5c2958)) * support model-backend async long run operation (instill-ai/console#309) ([f795ce8](instill-ai/console@f795ce8)) * update e2e test (instill-ai/console#313) ([88bf0cd](instill-ai/console@88bf0cd)) update how we test model detail page (instill-ai/console#310) ([04c83a1](instill-ai/console@04c83a1)) * wipe out all data after test (instill-ai/console#296) ([e4085dd](instill-ai/console@e4085dd)) ### Bug Fixes * fix pipeline e2e not stable (instill-ai/console#285) ([a26e599](instill-ai/console@a26e599)) * fix set-cookie api route issue due to wrong domain name (instill-ai/console#284) ([c3efcdd](instill-ai/console@c3efcdd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit