New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): add the file extension to the output filename #873

Merged

donch1989 merged 1 commit into main from huitang/ins-6945

Nov 25, 2024

Member

donch1989 commented Nov 25, 2024 •

edited

Loading

Because

The file extension is needed in the output filename to ensure MinIO downloads have a proper filename.

This commit

Adds the file extension to the output filename.
Removes unnecessary pointers to interfaces.


          feat(service): add file extension in output filename

3ab2326

donch1989 requested review from jvallesm and chuang8511 as code owners

November 25, 2024 13:12

linear bot commented Nov 25, 2024

INS-6945 Add the file extension to the pipeline trigger output filename

droplet-bot added the instill vdp label

donch1989 merged commit 22b92b0 into main

13 checks passed

donch1989 deleted the huitang/ins-6945 branch

November 25, 2024 13:43

droplet-bot mentioned this pull request

chore(main): release 0.48.0-beta #871

Merged

donch1989 pushed a commit that referenced this pull request


          chore(main): release 0.48.0-beta (#871)

78d11c8

🤖 I have created a release *beep* *boop*
---


##
[0.48.0-beta](v0.47.2-beta...v0.48.0-beta)
(2024-12-03)


### Features

* **component,data,base:** enhance component features
([#885](#885))
([68b396f](68b396f))
* **component,googlesheet:** implement the Google Sheet component
([#878](#878))
([8a0ab93](8a0ab93))
* **component,instillapp:** remove instill-app component
([#911](#911))
([4a7c970](4a7c970))
* **component,openai:** support streaming for o1-mini and o1-preview
models
([#882](#882))
([367e957](367e957))
* **component,schedule:** introduce the `schedule` component
([#900](#900))
([9582942](9582942))
* **connection:** add lookup connection endpoint
([#888](#888))
([86bffe8](86bffe8))
* **data:** add support for default value in `instill` Go tag
([#891](#891))
([b9c2d05](b9c2d05))
* **leadiq:** implement leadiq component
([#874](#874))
([78c2ec7](78c2ec7))
* **perplexity:** add perplexity component
([#861](#861))
([1fc7dbe](1fc7dbe))
* **recipe:** separate the template and the rendered value for input and
setup
([#886](#886))
([3ec3dd6](3ec3dd6))
* **recipe:** support `required` attribute for variable
([#901](#901))
([da7f0e9](da7f0e9))
* **service:** add the file extension to the output filename
([#873](#873))
([22b92b0](22b92b0))
* **service:** trigger latest release version for pipeline with
run-on-event setting
([#896](#896))
([0b1c071](0b1c071))
* **smartlead:** implement smartlead
([#879](#879))
([f6baf2a](f6baf2a))
* **text:** improve markdown chunking
([#889](#889))
([d48b3ec](d48b3ec))
* **trigger:** accept connection references in the pipeline trigger data
([#883](#883))
([937bd01](937bd01))
* **trigger:** enable optional values for variables
([#884](#884))
([187f5fd](187f5fd))
* **vdp:** skip google drive for cloud version
([#899](#899))
([5089397](5089397))


### Bug Fixes

* **ci:** use xk6-sql driver and pin down versions
([#876](#876))
([1f64d6c](1f64d6c))
* **component,openai:** enable the use of system messages with chat
history
([#905](#905))
([ef3e66f](ef3e66f))
* **leadiq, smartlead:** change field to optional
([#892](#892))
([9bd995d](9bd995d))
* **web:** fix url and markdown position
([#893](#893))
([af8f412](af8f412))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels