feat(artifact): add tag create / list endpoints #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvallesm
force-pushed
the
jvalles/ins-3958-implement-registry-tag-list
branch
from
a8706a5 to
3dca4de
Compare
triggered by commit: dada8fc
jvallesm
requested review from
donch1989,
heiruwu,
pinglin and
xiaofei-du
as code owners
jvallesm
force-pushed
the
jvalles/ins-3958-implement-registry-tag-list
branch
from
03fb2d0 to
ab738c8
Compare
triggered by commit: f632600
jvallesm
changed the title
2 tasks
jvallesm
added a commit
to instill-ai/artifact-backend
that referenced
this pull request
Mar 26, 2024
Because - In order to expose the tag list of an image in `repository`, we need to deploy `artifact-backend` and serve its API. This commit - Modifies the existing configuration and initialisation so `artifact-backend` can be built and run locally (`make build` / `make dev`) ## ⏭️ Next steps - [ ] `artifact-backend` will implement the endpoints added in instill-ai/protobufs#286 - [ ] `artifact-backend` should be built along with the other Instill services at [`instill-core`](https://github.com/instill-ai/instill-core) - The cloud versions of these repos should be updated, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This commit
api-gateway(when it detects the end of the image push operation) should communicate the creation of a tag.model-backendwill request this information to expose the model versions in the same family as the rest of the model endpoints.🗒️ Notes
As an initial addition to the Artifact domain, I made some naming choices. Please review and provide feedback about them.
⏭️ Next steps
artifact-backendwill implement a first version of this endpoint that will fetch the tag list from theregistryinstance. This endpoint only returns the tag list so the digest and update time will be empty.api-gatewaywill call the creation endpoint when we intercept aPUT manifestrequest. We'll store the digest and update time in theartifactdatabase and we'll aggregate that info to theregistrytag list (the registry should remain the source of truth).