-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(knowledge-base): follow the convention #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Besides the above comments, for consistency, we should use ListKnowledgeBases and GetKnowledgeBase for our gRPC endpoint naming.
- How do we handle getting KnowledgeBase from different owners?
- There are some typos in the PR title and message.
Hi @Yougigun , |
@donch1989 Thank you for pointing out. |
Hi, @Yougigun |
done. |
Because
of consistency with other services
This commit
follows the convention
Note:
this PR is only for POC, and there are some known issues will be refactored soon.