Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mgmt): remove aggregationWindow from pipeline trigger count request #396

Merged
merged 2 commits into from
Jul 25, 2024
Merged

fix(mgmt): remove aggregationWindow from pipeline trigger count request #396

merged 2 commits into from
Jul 25, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Jul 25, 2024 •
edited
Loading

Because

  • aggregation_window was copied as a param by accident (trigger count is not aggregated).

This commit

  • Removes the parameter from the trigger count request.

@jvallesm jvallesm self-assigned this Jul 25, 2024
@jvallesm jvallesm marked this pull request as ready for review July 25, 2024 12:09
@jvallesm jvallesm changed the title fix: remove aggregationWindow from pipeline trigger count request fix(mgmt): remove aggregationWindow from pipeline trigger count request Jul 25, 2024
@jvallesm jvallesm merged commit dacd560 into main Jul 25, 2024
1 of 2 checks passed
@jvallesm jvallesm deleted the jvalles/fix-trigger-count-req branch July 25, 2024 13:59
@droplet-bot droplet-bot mentioned this pull request Jul 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees

@jvallesm jvallesm

Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvallesm @donch1989 @droplet-bot