Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pipeline): add UID to integration object #443

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix(pipeline): add UID to integration object #443

merged 2 commits into from
Aug 30, 2024

Conversation

jvallesm
Copy link
Collaborator

Because

  • Connections reference integrations by UID internally, so it makes sense to
    have that field in the proto object instead of creating an internal
    representation. In component definitions, this field is already public.

This commit

  • Adds a UID field to the connection object.

@jvallesm jvallesm self-assigned this Aug 30, 2024
@linear Linear
Copy link

linear bot commented Aug 30, 2024

INS-5959 Manipulate Connections

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 30, 2024, 11:04 AM

@jvallesm jvallesm marked this pull request as ready for review August 30, 2024 11:03
@jvallesm jvallesm merged commit 548414d into main Aug 30, 2024
2 checks passed
@jvallesm jvallesm deleted the jvalles/ins-5959-manipulate-connections branch August 30, 2024 11:04
@droplet-bot droplet-bot mentioned this pull request Aug 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees

@jvallesm jvallesm

Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot