Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buf): use source_relative option to remove residual generated dir #455

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix(buf): use source_relative option to remove residual generated dir #455

merged 1 commit into from
Sep 18, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Sep 18, 2024 •
edited
Loading

Because

  • Option was missing from Buf generator, producing an unwanted directory in protogen-go

This commit

  • Uses source_relative option in the validate plugin

@jvallesm jvallesm self-assigned this Sep 18, 2024
@github-actions GitHub Actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 18, 2024, 2:07 PM

@jvallesm jvallesm marked this pull request as ready for review September 18, 2024 14:07
@jvallesm jvallesm merged commit a0e4212 into main Sep 18, 2024
12 checks passed
@jvallesm jvallesm deleted the jvalles/feat-add-protoc-gen-validate branch September 18, 2024 14:07
@droplet-bot droplet-bot mentioned this pull request Sep 18, 2024
Open
@jvallesm jvallesm mentioned this pull request Sep 18, 2024
Merged
donch1989 pushed a commit to instill-ai/protogen-go that referenced this pull request Sep 19, 2024
@jvallesm
chore(buf): clean up mistakenly committed directory (#63)
c99e9e6 
Because

- instill-ai/protobufs#455 fixes the
configuration that wrongly generated a package within this repo.

This commit

- Cleans up `./github.com/instill-ai/protogen-go/` directory after the
generated code no longer produces it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees

@jvallesm jvallesm

Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: 👋 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jvallesm