Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifact): rename SimilarityChunksSearch to ViewChunks #473

Merged
merged 2 commits into from
Sep 27, 2024
Merged

feat(artifact): rename SimilarityChunksSearch to ViewChunks #473

merged 2 commits into from
Sep 27, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Sep 27, 2024 •
edited
Loading

Because

  • Python SDK artifact_client functions, and the documentation should be consistent to ensure clarity and ease of use.

This commit

  • rename SimilarityChunksSearch to ViewChunks

@linear Linear
Copy link

linear bot commented Sep 27, 2024

INS-6311 [Improvement] Make Python SDK Consistent with Artifact-Backend API

@github-actions GitHub Actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedSep 27, 2024, 6:29 AM

@joremysh joremysh merged commit 8aff3ef into main Sep 27, 2024
1 check passed
@joremysh joremysh deleted the jeremy/ins-6311-catchup-with-artifact-backend branch September 27, 2024 06:34
@droplet-bot droplet-bot mentioned this pull request Sep 27, 2024
Open
Yougigun added a commit that referenced this pull request Sep 27, 2024
@Yougigun
Revert "feat(artifact): rename SimilarityChunksSearch to ViewChunks (#…
cf3489f 
…473)"

This reverts commit 8aff3ef.
@Yougigun Yougigun mentioned this pull request Sep 27, 2024
Merged
Yougigun added a commit that referenced this pull request Sep 27, 2024
@Yougigun
fix(artifact): rename ViewChunks to SimilarityChunksSearch (#474)
329f572 
Reverts #473

Because

accidentally there was a misundersatnding regarding the revising
document requirement.

This commit 

revert the change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 donch1989 approved these changes

@heiruwu heiruwu Awaiting requested review from heiruwu heiruwu is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joremysh @donch1989 @droplet-bot