Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(buf): remove protoc-gen-validate #475

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Sep 27, 2024

Because

  • protoc-gen-validate does not fully support as buf plugin for generating python code

This commit

  • remove protoc-gen-validate

Copy link

linear bot commented Sep 27, 2024

Copy link

github-actions bot commented Sep 27, 2024

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedOct 2, 2024, 7:06 AM

@joremysh joremysh force-pushed the jeremy/ins-6311-catchup-with-artifact-backend branch 2 times, most recently from f5b80ad to 26ed4b0 Compare September 27, 2024 14:51
@joremysh joremysh force-pushed the jeremy/ins-6311-catchup-with-artifact-backend branch from 26ed4b0 to e6797fa Compare September 27, 2024 15:29
donch1989 pushed a commit to instill-ai/pipeline-backend that referenced this pull request Sep 30, 2024
Because

- instill-ai/protobufs#475 removes
`protoc-gen-validate` because it breaks the generated code used in the
Python SDK.
This commit

- Removes the dependencies from that package.
@jvallesm jvallesm merged commit 54137c1 into main Oct 2, 2024
13 of 14 checks passed
@jvallesm jvallesm deleted the jeremy/ins-6311-catchup-with-artifact-backend branch October 2, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants