Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine report in metrics #164

Closed
hsane-dev opened this issue Jan 22, 2025 · 2 comments · Fixed by #171
Closed

Combine report in metrics #164

hsane-dev opened this issue Jan 22, 2025 · 2 comments · Fixed by #171
Labels
enhancement New feature or request

Comments

@hsane-dev
Copy link

If the call to "metrics" can be preceded by "report" we can get the svr_info report and the metrics in a single invocation of perfspect. Ofcourse one could invoke "perfspect report" && "perfspect metrics" but I believe this would still create 2 htnls, one for report and another for metrics. Can the htmls be combined into one, allowing reference to just one html result file. This could be done by adding a "report" flag to the "metrics" option and combining html in that case, while default if not combined.

@harp-intel harp-intel added the enhancement New feature or request label Jan 23, 2025
@harp-intel
Copy link
Contributor

Hi @hsane-dev ,

I understand the request. It would require a significant change to the application structure as the commands (report, metrics, telemetry, etc.) are very separate from a design standpoint. It would also require merging of the metrics and report HTML generation code, which for historical reasons is designed differently. In other words, this would be a large task. Not impossible, but would take the application in a direction I'm not currently willing to invest in.

That said, there may be some partial steps that can be taken within the metrics command itself. Some system data is already collected for the "metadata" but is only exposed in the log file. We may be able to surface some of this into the HTML report.

@hsane-dev
Copy link
Author

Thanks, understandable that its a larger task. If major env variables from sys env can be converted into a "configuration" tab from the meta data, it would still be very useful. Thanks for considering.

@harp-intel harp-intel linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants