From 30a79c001d8004a4e3596f76cb903efcb0194c0d Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Thu, 5 Sep 2024 14:37:55 -0700 Subject: [PATCH 01/26] Run E2E tests on PVC, with and without dev-igc --- .github/workflows/sycl-linux-precommit.yml | 15 +++++++++++++++ .github/workflows/sycl-linux-run-tests.yml | 1 + devops/containers/ubuntu2204_base.Dockerfile | 5 +++++ 3 files changed, 21 insertions(+) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 424ade23f1b08..0e811e388fad8 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -89,6 +89,21 @@ jobs: reset_intel_gpu: true install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} extra_lit_opts: --param gpu-intel-gen12=True + - name: E2E tests on Intel Ponte Vecchio GPU + runner: '["Linux", "pvc"]' + image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest + image_options: -u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN + target_devices: ext_oneapi_level_zero:gpu;opencl:gpu + install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} + - name: E2E tests with dev igc on Intel Ponte Vecchio GPU + runner: '["Linux", "pvc"]' + image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') && 'latest' || 'devigc' }} + image_options: -u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN + target_devices: ext_oneapi_level_zero:gpu;opencl:gpu + install_drivers: >- + ${{ contains(needs.detect_changes.outputs.filters, 'drivers') || + contains(needs.detect_changes.outputs.filters, 'devigccfg') }} + use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }} - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest diff --git a/.github/workflows/sycl-linux-run-tests.yml b/.github/workflows/sycl-linux-run-tests.yml index 1f3cbd5f156b1..efcf8de963c2d 100644 --- a/.github/workflows/sycl-linux-run-tests.yml +++ b/.github/workflows/sycl-linux-run-tests.yml @@ -84,6 +84,7 @@ on: - '["Linux", "gen12"]' - '["amdgpu"]' - '["Linux", "arc"]' + - '["Linux", "pvc"]' - '["cts-cpu"]' image: description: | diff --git a/devops/containers/ubuntu2204_base.Dockerfile b/devops/containers/ubuntu2204_base.Dockerfile index 543e600b09f7b..43a71f93e5ad3 100644 --- a/devops/containers/ubuntu2204_base.Dockerfile +++ b/devops/containers/ubuntu2204_base.Dockerfile @@ -16,6 +16,11 @@ RUN groupadd -g 1001 sycl && useradd sycl -u 1001 -g 1001 -m -s /bin/bash # Add sycl user to video/irc groups so that it can access GPU RUN usermod -aG video sycl RUN usermod -aG irc sycl + +# 109 group is required for sycl user to access PVC card. +RUN groupadd -g 109 render +RUN usermod -aG render sycl + # Allow sycl user to run as sudo RUN echo "sycl ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers From 5f527b20a23b8d92779bd39724524e227bffc8b1 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Thu, 5 Sep 2024 15:06:22 -0700 Subject: [PATCH 02/26] Remove group-add 109 --- .github/workflows/sycl-linux-precommit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 0e811e388fad8..0b2a7c37ee845 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -92,13 +92,13 @@ jobs: - name: E2E tests on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest - image_options: -u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN + image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') && 'latest' || 'devigc' }} - image_options: -u 1001 --group-add 109 --device=/dev/dri --privileged --cap-add SYS_ADMIN + image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu install_drivers: >- ${{ contains(needs.detect_changes.outputs.filters, 'drivers') || From 9c968e1c3c73a585572ea5aaa5358b472c38d4a5 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Sat, 7 Sep 2024 08:31:02 -0700 Subject: [PATCH 03/26] Slip run on dev-igc --- .github/workflows/sycl-linux-precommit.yml | 4 +++- devops/scripts/docker_entrypoint.sh | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 2291f2724575c..a0cbea9ebba18 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -97,13 +97,15 @@ jobs: install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' - image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') && 'latest' || 'devigc' }} + image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu install_drivers: >- ${{ contains(needs.detect_changes.outputs.filters, 'drivers') || contains(needs.detect_changes.outputs.filters, 'devigccfg') }} use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }} + # Run only if the PR does not have the 'ci-no-devigc' label. + skip_run: ${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') }} - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest diff --git a/devops/scripts/docker_entrypoint.sh b/devops/scripts/docker_entrypoint.sh index f0e89244d013f..a1e1d9105d68c 100755 --- a/devops/scripts/docker_entrypoint.sh +++ b/devops/scripts/docker_entrypoint.sh @@ -5,4 +5,8 @@ if [ -d "$GITHUB_WORKSPACE" ]; then su sycl fi +groups sycl +usermod -aG render sycl || true +groups sycl + exec "$@" From 4f068df7c2428c908d33f465bf6864418858c3ac Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Sat, 7 Sep 2024 10:01:15 -0700 Subject: [PATCH 04/26] Seperate out changes in containers --- devops/containers/ubuntu2204_base.Dockerfile | 5 ----- devops/scripts/docker_entrypoint.sh | 4 ---- 2 files changed, 9 deletions(-) diff --git a/devops/containers/ubuntu2204_base.Dockerfile b/devops/containers/ubuntu2204_base.Dockerfile index 43a71f93e5ad3..543e600b09f7b 100644 --- a/devops/containers/ubuntu2204_base.Dockerfile +++ b/devops/containers/ubuntu2204_base.Dockerfile @@ -16,11 +16,6 @@ RUN groupadd -g 1001 sycl && useradd sycl -u 1001 -g 1001 -m -s /bin/bash # Add sycl user to video/irc groups so that it can access GPU RUN usermod -aG video sycl RUN usermod -aG irc sycl - -# 109 group is required for sycl user to access PVC card. -RUN groupadd -g 109 render -RUN usermod -aG render sycl - # Allow sycl user to run as sudo RUN echo "sycl ALL=(ALL) NOPASSWD:ALL" >> /etc/sudoers diff --git a/devops/scripts/docker_entrypoint.sh b/devops/scripts/docker_entrypoint.sh index a1e1d9105d68c..f0e89244d013f 100755 --- a/devops/scripts/docker_entrypoint.sh +++ b/devops/scripts/docker_entrypoint.sh @@ -5,8 +5,4 @@ if [ -d "$GITHUB_WORKSPACE" ]; then su sycl fi -groups sycl -usermod -aG render sycl || true -groups sycl - exec "$@" From 9e96d5af5af0794b4a16ee34a53140559752e30c Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Thu, 12 Sep 2024 15:37:32 -0700 Subject: [PATCH 05/26] Disable ASAN tests on PVC --- sycl/test-e2e/AddressSanitizer/lit.local.cfg | 2 +- .../Matrix/SPVCooperativeMatrix/joint_matrix_prefetch.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sycl/test-e2e/AddressSanitizer/lit.local.cfg b/sycl/test-e2e/AddressSanitizer/lit.local.cfg index 8eb37fb1a7b43..0cc3f700b7b93 100644 --- a/sycl/test-e2e/AddressSanitizer/lit.local.cfg +++ b/sycl/test-e2e/AddressSanitizer/lit.local.cfg @@ -11,4 +11,4 @@ config.substitutions.append( config.unsupported_features += ['cuda', 'hip'] # FIXME: Skip gen devices, waiting for gfx driver uplifting -config.unsupported_features += ['gpu-intel-gen9', 'gpu-intel-gen11', 'gpu-intel-gen12', 'gpu-intel-dg2', 'gpu-intel-pvc'] +config.unsupported_features += ['gpu-intel-gen9', 'gpu-intel-gen11', 'gpu-intel-gen12', 'gpu-intel-dg2', 'gpu-intel-pvc', 'arch-intel_gpu_pvc'] diff --git a/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_prefetch.cpp b/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_prefetch.cpp index 3bf4dd7608f48..cc1c848f82fba 100644 --- a/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_prefetch.cpp +++ b/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_prefetch.cpp @@ -11,7 +11,7 @@ // XFAIL: cpu // https://github.com/intel/llvm/issues/14826 -// XFAIL: arch-intel_gpu_pvc && !dev-igc +// XFAIL: arch-intel_gpu_pvc && !igc-dev #include "../common.hpp" From 036cab27866f6200609f2741b5918d3aede71386 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Thu, 12 Sep 2024 16:11:42 -0700 Subject: [PATCH 06/26] Add gpu-intel-pvc LIT option --- .github/workflows/sycl-linux-precommit.yml | 2 ++ sycl/test-e2e/AddressSanitizer/lit.local.cfg | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 16f1cb043905b..e58e63f7929e7 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -94,6 +94,7 @@ jobs: image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} + extra_lit_opts: --param gpu-intel-pvc=True - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc @@ -105,6 +106,7 @@ jobs: use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }} # Run only if the PR does not have the 'ci-no-devigc' label. skip_run: ${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') }} + extra_lit_opts: --param gpu-intel-pvc=True - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest diff --git a/sycl/test-e2e/AddressSanitizer/lit.local.cfg b/sycl/test-e2e/AddressSanitizer/lit.local.cfg index 0cc3f700b7b93..8eb37fb1a7b43 100644 --- a/sycl/test-e2e/AddressSanitizer/lit.local.cfg +++ b/sycl/test-e2e/AddressSanitizer/lit.local.cfg @@ -11,4 +11,4 @@ config.substitutions.append( config.unsupported_features += ['cuda', 'hip'] # FIXME: Skip gen devices, waiting for gfx driver uplifting -config.unsupported_features += ['gpu-intel-gen9', 'gpu-intel-gen11', 'gpu-intel-gen12', 'gpu-intel-dg2', 'gpu-intel-pvc', 'arch-intel_gpu_pvc'] +config.unsupported_features += ['gpu-intel-gen9', 'gpu-intel-gen11', 'gpu-intel-gen12', 'gpu-intel-dg2', 'gpu-intel-pvc'] From 65e29ff746083c0e082532417f283f6cca04b925 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Fri, 13 Sep 2024 08:18:58 -0700 Subject: [PATCH 07/26] Disable ASAN tests on PVC --- sycl/test-e2e/AddressSanitizer/lit.local.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/test-e2e/AddressSanitizer/lit.local.cfg b/sycl/test-e2e/AddressSanitizer/lit.local.cfg index 8eb37fb1a7b43..0cc3f700b7b93 100644 --- a/sycl/test-e2e/AddressSanitizer/lit.local.cfg +++ b/sycl/test-e2e/AddressSanitizer/lit.local.cfg @@ -11,4 +11,4 @@ config.substitutions.append( config.unsupported_features += ['cuda', 'hip'] # FIXME: Skip gen devices, waiting for gfx driver uplifting -config.unsupported_features += ['gpu-intel-gen9', 'gpu-intel-gen11', 'gpu-intel-gen12', 'gpu-intel-dg2', 'gpu-intel-pvc'] +config.unsupported_features += ['gpu-intel-gen9', 'gpu-intel-gen11', 'gpu-intel-gen12', 'gpu-intel-dg2', 'gpu-intel-pvc', 'arch-intel_gpu_pvc'] From 529f50065577f727db0677598c53f330f0413afb Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Fri, 13 Sep 2024 09:48:40 -0700 Subject: [PATCH 08/26] Limit # of concurrent E2E test runs on PVC machine --- .github/workflows/sycl-linux-precommit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index e58e63f7929e7..94e113a0bbbea 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -94,7 +94,7 @@ jobs: image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} - extra_lit_opts: --param gpu-intel-pvc=True + extra_lit_opts: --param gpu-intel-pvc=True -j 20 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc @@ -106,7 +106,7 @@ jobs: use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }} # Run only if the PR does not have the 'ci-no-devigc' label. skip_run: ${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') }} - extra_lit_opts: --param gpu-intel-pvc=True + extra_lit_opts: --param gpu-intel-pvc=True -j 20 - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest From cec74ff29e9d910f2c06d4e8b2d0edb9e753618d Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Fri, 13 Sep 2024 15:22:52 -0700 Subject: [PATCH 09/26] XFAIL failing tests --- sycl/test-e2e/ESIMD/mask_expand_load.cpp | 3 --- sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sycl/test-e2e/ESIMD/mask_expand_load.cpp b/sycl/test-e2e/ESIMD/mask_expand_load.cpp index 2605e0ed3b0ba..13c9f6c04e102 100644 --- a/sycl/test-e2e/ESIMD/mask_expand_load.cpp +++ b/sycl/test-e2e/ESIMD/mask_expand_load.cpp @@ -9,9 +9,6 @@ // RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out // RUN: %{run} %t.out -// https://github.com/intel/llvm/issues/14826 -// XFAIL: arch-intel_gpu_pvc - // This is a basic test to validate the expanded load API. #include "esimd_test_utils.hpp" diff --git a/sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp b/sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp index 511f713b7c95c..c367911b63f99 100644 --- a/sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp +++ b/sycl/test-e2e/KernelCompiler/kernel_compiler_sycl.cpp @@ -9,6 +9,9 @@ // REQUIRES: (opencl || level_zero) // UNSUPPORTED: accelerator +// https://github.com/intel/llvm/issues/14826 +// XFAIL: arch-intel_gpu_pvc && igc-dev + // RUN: %{build} -o %t.out // RUN: %{run} %t.out From a5b1e2e9b8b61f158f1a72eabb33bfca8e73fbf0 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Mon, 16 Sep 2024 09:56:05 -0700 Subject: [PATCH 10/26] Disable mask_expand_load --- sycl/test-e2e/ESIMD/mask_expand_load.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sycl/test-e2e/ESIMD/mask_expand_load.cpp b/sycl/test-e2e/ESIMD/mask_expand_load.cpp index 13c9f6c04e102..2605e0ed3b0ba 100644 --- a/sycl/test-e2e/ESIMD/mask_expand_load.cpp +++ b/sycl/test-e2e/ESIMD/mask_expand_load.cpp @@ -9,6 +9,9 @@ // RUN: %{build} -fsycl-device-code-split=per_kernel -o %t.out // RUN: %{run} %t.out +// https://github.com/intel/llvm/issues/14826 +// XFAIL: arch-intel_gpu_pvc + // This is a basic test to validate the expanded load API. #include "esimd_test_utils.hpp" From 2566c73621f44e45408357d2a00c08920a52cdda Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Sep 2024 10:40:57 -0700 Subject: [PATCH 11/26] Address reviews --- .github/workflows/sycl-linux-precommit.yml | 12 +++--------- .../joint_matrix_bf16_fill_k_cache_OOB.cpp | 3 --- .../Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp | 3 --- 3 files changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 3fb5656c821fb..7f6bfa8011cc1 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -92,20 +92,14 @@ jobs: image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }} - extra_lit_opts: --param gpu-intel-pvc=True -j 20 + extra_lit_opts: --param gpu-intel-pvc=True --param matrix=1 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - install_drivers: >- - ${{ contains(needs.detect_changes.outputs.filters, 'drivers') || - contains(needs.detect_changes.outputs.filters, 'devigccfg') }} - use_dev_igc: ${{ contains(needs.detect_changes.outputs.filters, 'devigccfg') }} - # Run only if the PR does not have the 'ci-no-devigc' label. - skip_run: ${{ contains(github.event.pull_request.labels.*.name, 'ci-no-devigc') }} - extra_lit_opts: --param gpu-intel-pvc=True -j 20 + extra_lit_opts: --param gpu-intel-pvc=True --param matrix=1 + use_igc_dev: true - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest diff --git a/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_bf16_fill_k_cache_OOB.cpp b/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_bf16_fill_k_cache_OOB.cpp index ffa651fc98d58..af4b28e090b4c 100644 --- a/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_bf16_fill_k_cache_OOB.cpp +++ b/sycl/test-e2e/Matrix/SPVCooperativeMatrix/joint_matrix_bf16_fill_k_cache_OOB.cpp @@ -8,9 +8,6 @@ // REQUIRES: aspect-ext_intel_matrix, gpu // UNSUPPORTED: gpu-intel-dg2 -// https://github.com/intel/llvm/issues/14826 -// XFAIL: arch-intel_gpu_pvc && igc-dev - // RUN: %{build} -D__SPIRV_USE_COOPERATIVE_MATRIX -o %t_gpu_vnni.out -ffp-model=precise -DOOB -DVNNI // RUN: %{run} %t_gpu_vnni.out diff --git a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp index ad0cda4824b76..0f2c8c71bd223 100644 --- a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp +++ b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_OOB.cpp @@ -8,9 +8,6 @@ // REQUIRES: aspect-ext_intel_matrix, gpu // UNSUPPORTED: gpu-intel-dg2 -// https://github.com/intel/llvm/issues/14826 -// XFAIL: arch-intel_gpu_pvc && igc-dev - // RUN: %{build} -o %t_gpu_vnni.out -ffp-model=precise -DOOB -DVNNI // RUN: %{run} %t_gpu_vnni.out From 4920145af92dd686630bd8ee712105efead7c2b9 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Sep 2024 11:28:48 -0700 Subject: [PATCH 12/26] Temporarily Increase E2E tests timeout to 20min --- sycl/test-e2e/lit.cfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/test-e2e/lit.cfg.py b/sycl/test-e2e/lit.cfg.py index f7d56aaee8f8e..8138722fd3dfd 100644 --- a/sycl/test-e2e/lit.cfg.py +++ b/sycl/test-e2e/lit.cfg.py @@ -815,6 +815,6 @@ def open_check_file(file_name): try: import psutil - lit_config.maxIndividualTestTime = 600 + lit_config.maxIndividualTestTime = 1200 except ImportError: pass From 83e562a8282870edc3911a89d75aaca1d0b3cef7 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Wed, 18 Sep 2024 09:48:54 -0700 Subject: [PATCH 13/26] Remove --param LIT options from PVC workflow --- .github/workflows/sycl-linux-precommit.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index 7f6bfa8011cc1..cf102847358ec 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -92,13 +92,11 @@ jobs: image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - extra_lit_opts: --param gpu-intel-pvc=True --param matrix=1 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - extra_lit_opts: --param gpu-intel-pvc=True --param matrix=1 use_igc_dev: true - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' From 8f5692a48068dbae58ab387cda93dde9e0268075 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Thu, 26 Sep 2024 09:22:01 -0700 Subject: [PATCH 14/26] Reset test time --- sycl/test-e2e/lit.cfg.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/test-e2e/lit.cfg.py b/sycl/test-e2e/lit.cfg.py index 625313040aca7..c2582467dd4cf 100644 --- a/sycl/test-e2e/lit.cfg.py +++ b/sycl/test-e2e/lit.cfg.py @@ -790,6 +790,6 @@ def open_check_file(file_name): try: import psutil - lit_config.maxIndividualTestTime = 1200 + lit_config.maxIndividualTestTime = 600 except ImportError: pass From 14fcf2d2c6121ae18400b833b508e48b81840d76 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Dec 2024 09:55:57 -0800 Subject: [PATCH 15/26] Move PVC run to post-commit --- .github/workflows/sycl-linux-precommit.yml | 11 ----------- .github/workflows/sycl-post-commit.yml | 13 +++++++++++++ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/.github/workflows/sycl-linux-precommit.yml b/.github/workflows/sycl-linux-precommit.yml index f8f53d4b99734..04665c383cbb6 100644 --- a/.github/workflows/sycl-linux-precommit.yml +++ b/.github/workflows/sycl-linux-precommit.yml @@ -97,17 +97,6 @@ jobs: target_devices: level_zero:gpu;opencl:gpu;opencl:cpu reset_intel_gpu: true extra_lit_opts: --param gpu-intel-gen12=True - - name: E2E tests on Intel Ponte Vecchio GPU - runner: '["Linux", "pvc"]' - image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest - image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN - target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - - name: E2E tests with dev igc on Intel Ponte Vecchio GPU - runner: '["Linux", "pvc"]' - image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc - image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN - target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - use_igc_dev: true - name: E2E tests on Intel Arc A-Series Graphics runner: '["Linux", "arc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index 6817693e02be3..c7517463021c1 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -60,6 +60,19 @@ jobs: image_options: -u 1001 --device=/dev/dri --device=/dev/kfd target_devices: ext_oneapi_hip:gpu reset_intel_gpu: false + - name: E2E tests on Intel Ponte Vecchio GPU + runner: '["Linux", "pvc"]' + image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest + image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN + target_devices: ext_oneapi_level_zero:gpu;opencl:gpu + extra_lit_opts: --param gpu-intel-pvc=True -j 100 + - name: E2E tests with dev igc on Intel Ponte Vecchio GPU + runner: '["Linux", "pvc"]' + image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc + image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN + target_devices: ext_oneapi_level_zero:gpu;opencl:gpu + use_igc_dev: true + extra_lit_opts: --param gpu-intel-pvc=True -j 100 # Performance tests below. Specifics: # - only run performance tests (use LIT_FILTER env) # - ask llvm-lit to show all the output, even for PASS (-a) From 9d4b506f95eb0d44ad24c6ef2d2cebc9e4df8ae9 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Dec 2024 11:23:37 -0800 Subject: [PATCH 16/26] Remove --param gpu-intel-pvc=True --- .github/workflows/sycl-post-commit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index c7517463021c1..15f64e2578684 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -65,14 +65,14 @@ jobs: image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - extra_lit_opts: --param gpu-intel-pvc=True -j 100 + extra_lit_opts: -j 100 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu use_igc_dev: true - extra_lit_opts: --param gpu-intel-pvc=True -j 100 + extra_lit_opts: -j 100 # Performance tests below. Specifics: # - only run performance tests (use LIT_FILTER env) # - ask llvm-lit to show all the output, even for PASS (-a) From 4f6598d5206baac9eca8ea0ee2d8c415b001ea90 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Dec 2024 11:48:35 -0800 Subject: [PATCH 17/26] XFAIL E2E tests failing on PVC --- sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp | 3 +++ sycl/test-e2e/Basic/accessor/accessor.cpp | 3 +++ sycl/test-e2e/DeviceCodeSplit/grf.cpp | 2 ++ sycl/test-e2e/ESIMD/accessor_local.cpp | 2 +- sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp | 2 +- sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp | 2 +- .../ESIMD/lsc/lsc_local_accessor_block_load_store.cpp | 2 +- .../KernelAndProgram/persistent-cache-multi-device.cpp | 3 +++ .../Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp | 3 +++ .../Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp | 3 +++ sycl/test-e2e/MemorySanitizer/check_buffer.cpp | 2 ++ sycl/test-e2e/MemorySanitizer/check_call.cpp | 2 ++ sycl/test-e2e/MemorySanitizer/check_divide.cpp | 2 ++ .../ProgramManager/multi_device_bundle/build_twice.cpp | 3 +++ .../multi_device_bundle/device_libs_and_caching.cpp | 3 +++ sycl/test-e2e/Regression/multithread_write_accessor.cpp | 4 ++++ sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp | 3 +++ 17 files changed, 40 insertions(+), 4 deletions(-) diff --git a/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp b/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp index 2830241eda489..53b73ab68b217 100644 --- a/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp +++ b/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp @@ -4,6 +4,9 @@ // RUN: %{build} %device_asan_flags %if cpu %{ -fsycl-targets=spir64_x86_64 %} %if gpu %{ -fsycl-targets=spir64_gen -Xsycl-target-backend=spir64_gen %gpu_aot_target_opts %} -O2 -fsanitize-ignorelist=%p/ignorelist.txt -o %t2 // RUN: %{run} %t2 2>&1 | FileCheck %s +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include #include diff --git a/sycl/test-e2e/Basic/accessor/accessor.cpp b/sycl/test-e2e/Basic/accessor/accessor.cpp index de944ba12754a..a84afdd46c24c 100644 --- a/sycl/test-e2e/Basic/accessor/accessor.cpp +++ b/sycl/test-e2e/Basic/accessor/accessor.cpp @@ -1,6 +1,9 @@ // RUN: %{build} -DSYCL2020_DISABLE_DEPRECATION_WARNINGS -o %t.out // RUN: %{run} %t.out +// XFAIL: arch-intel_gpu_pvc && igc-dev +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + //==----------------accessor.cpp - SYCL accessor basic test ----------------==// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. diff --git a/sycl/test-e2e/DeviceCodeSplit/grf.cpp b/sycl/test-e2e/DeviceCodeSplit/grf.cpp index b3d02a7fea35c..1e5b085d207d6 100644 --- a/sycl/test-e2e/DeviceCodeSplit/grf.cpp +++ b/sycl/test-e2e/DeviceCodeSplit/grf.cpp @@ -14,6 +14,8 @@ // compiler option // REQUIRES: arch-intel_gpu_pvc +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 // RUN: %{build} -Wno-error=deprecated-declarations -o %t1.out // RUN: env SYCL_UR_TRACE=2 %{run} %t1.out 2>&1 | FileCheck %s --check-prefixes=CHECK,CHECK-NO-VAR diff --git a/sycl/test-e2e/ESIMD/accessor_local.cpp b/sycl/test-e2e/ESIMD/accessor_local.cpp index 21382f8ee401c..72c65292dcb09 100644 --- a/sycl/test-e2e/ESIMD/accessor_local.cpp +++ b/sycl/test-e2e/ESIMD/accessor_local.cpp @@ -1,5 +1,5 @@ // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev +// XFAIL: igc-dev && !arch-intel_gpu_pvc // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp b/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp index ce8b4d30d0928..a52634f962f19 100644 --- a/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp +++ b/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev +// XFAIL: igc-dev && !arch-intel_gpu_pvc // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp b/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp index c63411b286b32..4733380944714 100644 --- a/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp +++ b/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev +// XFAIL: igc-dev && !arch-intel_gpu_pvc // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp b/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp index 790b7dc2a92da..7a6f9b8ab692c 100644 --- a/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp +++ b/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp @@ -7,7 +7,7 @@ //===----------------------------------------------------------------------===// // REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2 // REQUIRES-INTEL-DRIVER: lin: 26690, win: 101.4576 -// XFAIL: igc-dev +// XFAIL: igc-dev && !arch-intel_gpu_pvc // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/KernelAndProgram/persistent-cache-multi-device.cpp b/sycl/test-e2e/KernelAndProgram/persistent-cache-multi-device.cpp index 48a9bdf74d8cf..24cfb57341e12 100644 --- a/sycl/test-e2e/KernelAndProgram/persistent-cache-multi-device.cpp +++ b/sycl/test-e2e/KernelAndProgram/persistent-cache-multi-device.cpp @@ -5,6 +5,9 @@ // RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 SYCL_CACHE_PERSISTENT=1 SYCL_CACHE_TRACE=1 SYCL_CACHE_DIR=%t/cache_dir env -u XDG_CACHE_HOME env -u HOME %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-BUILD // RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 SYCL_CACHE_PERSISTENT=1 SYCL_CACHE_TRACE=1 SYCL_CACHE_DIR=%t/cache_dir env -u XDG_CACHE_HOME env -u HOME %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-CACHE +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + // Test checks that persistent cache works correctly with multiple devices. #include diff --git a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp index febb1230d91dd..e5335729a7d4d 100644 --- a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp +++ b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp @@ -17,5 +17,8 @@ // XFAIL: !igc-dev || gpu-intel-dg2 // XFAIL-TRACKER: CMPLRLLVM-63710 +// XFAIL: arch-intel_gpu_pvc && igc-dev +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include "common.hpp" #include "joint_matrix_bf16_fill_k_cache_impl.hpp" diff --git a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp index 291852eaa612d..d522301d3296c 100644 --- a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp +++ b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp @@ -17,5 +17,8 @@ // XFAIL: !igc-dev || gpu-intel-dg2 // XFAIL-TRACKER: CMPLRLLVM-63710 +// XFAIL: arch-intel_gpu_pvc && igc-dev +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include "common.hpp" #include "joint_matrix_bf16_fill_k_cache_impl.hpp" diff --git a/sycl/test-e2e/MemorySanitizer/check_buffer.cpp b/sycl/test-e2e/MemorySanitizer/check_buffer.cpp index dfce88803a96e..69482e5ac7398 100644 --- a/sycl/test-e2e/MemorySanitizer/check_buffer.cpp +++ b/sycl/test-e2e/MemorySanitizer/check_buffer.cpp @@ -6,6 +6,8 @@ // XFAIL: gpu-intel-gen12 || gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16184 +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 #include diff --git a/sycl/test-e2e/MemorySanitizer/check_call.cpp b/sycl/test-e2e/MemorySanitizer/check_call.cpp index fc1d41ac4c1e8..869bbab56021e 100644 --- a/sycl/test-e2e/MemorySanitizer/check_call.cpp +++ b/sycl/test-e2e/MemorySanitizer/check_call.cpp @@ -6,6 +6,8 @@ // XFAIL: gpu-intel-gen12 || gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16184 +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 #include #include diff --git a/sycl/test-e2e/MemorySanitizer/check_divide.cpp b/sycl/test-e2e/MemorySanitizer/check_divide.cpp index 4769e1a3b9d44..a0f0260569cf4 100644 --- a/sycl/test-e2e/MemorySanitizer/check_divide.cpp +++ b/sycl/test-e2e/MemorySanitizer/check_divide.cpp @@ -6,6 +6,8 @@ // XFAIL: gpu-intel-gen12 || gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16184 +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 #include #include diff --git a/sycl/test-e2e/ProgramManager/multi_device_bundle/build_twice.cpp b/sycl/test-e2e/ProgramManager/multi_device_bundle/build_twice.cpp index d4aaea78c7173..a0069d81fe2d6 100644 --- a/sycl/test-e2e/ProgramManager/multi_device_bundle/build_twice.cpp +++ b/sycl/test-e2e/ProgramManager/multi_device_bundle/build_twice.cpp @@ -6,6 +6,9 @@ // RUN: %{build} -o %t.out // RUN: env NEOReadDebugKeys=1 CreateMultipleRootDevices=3 SYCL_UR_TRACE=2 %{run} %t.out | FileCheck %s +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include #include diff --git a/sycl/test-e2e/ProgramManager/multi_device_bundle/device_libs_and_caching.cpp b/sycl/test-e2e/ProgramManager/multi_device_bundle/device_libs_and_caching.cpp index d596518165762..9fd107ce95a70 100644 --- a/sycl/test-e2e/ProgramManager/multi_device_bundle/device_libs_and_caching.cpp +++ b/sycl/test-e2e/ProgramManager/multi_device_bundle/device_libs_and_caching.cpp @@ -28,6 +28,9 @@ // Check the case when in-memory caching of the programs is disabled. // RUN: env SYCL_CACHE_IN_MEM=0 NEOReadDebugKeys=1 CreateMultipleRootDevices=4 %{run} %t.out +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include #include #include diff --git a/sycl/test-e2e/Regression/multithread_write_accessor.cpp b/sycl/test-e2e/Regression/multithread_write_accessor.cpp index c8ef2c534d57a..87299ed3e4d5c 100644 --- a/sycl/test-e2e/Regression/multithread_write_accessor.cpp +++ b/sycl/test-e2e/Regression/multithread_write_accessor.cpp @@ -1,5 +1,9 @@ // RUN: %{build} -o %t.out %threads_lib // RUN: %{run} %t.out + +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include #include diff --git a/sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp b/sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp index b5c82af8938df..033f5c99d74e1 100644 --- a/sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp +++ b/sycl/test-e2e/syclcompat/launch/launch_policy_lmem.cpp @@ -26,6 +26,9 @@ // UNSUPPORTED: linux && opencl && (gpu-intel-gen12 || gpu-intel-dg2) // UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/15275 +// XFAIL: arch-intel_gpu_pvc +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + #include #include #include From 20878380e2ae053ce20a46ac3ec1fca4d41e5bd5 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Dec 2024 12:49:29 -0800 Subject: [PATCH 18/26] Fix XFAILS --- sycl/test-e2e/ESIMD/accessor_local.cpp | 2 +- sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp | 2 +- sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp | 2 +- sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sycl/test-e2e/ESIMD/accessor_local.cpp b/sycl/test-e2e/ESIMD/accessor_local.cpp index 72c65292dcb09..bb6847d903919 100644 --- a/sycl/test-e2e/ESIMD/accessor_local.cpp +++ b/sycl/test-e2e/ESIMD/accessor_local.cpp @@ -1,5 +1,5 @@ // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev && !arch-intel_gpu_pvc +// XFAIL: igc-dev && gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp b/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp index a52634f962f19..e1cb2ed7f51f3 100644 --- a/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp +++ b/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev && !arch-intel_gpu_pvc +// XFAIL: igc-dev && gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp b/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp index 4733380944714..179ae3d118acc 100644 --- a/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp +++ b/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev && !arch-intel_gpu_pvc +// XFAIL: igc-dev && gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp b/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp index 7a6f9b8ab692c..f180dff3e8a8c 100644 --- a/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp +++ b/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp @@ -7,7 +7,7 @@ //===----------------------------------------------------------------------===// // REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2 // REQUIRES-INTEL-DRIVER: lin: 26690, win: 101.4576 -// XFAIL: igc-dev && !arch-intel_gpu_pvc +// XFAIL: igc-dev && gpu-intel-dg2 // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out From 45b0c0ae35eed6a570498fa7af8d3dec74d1b8f9 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Dec 2024 14:10:57 -0800 Subject: [PATCH 19/26] One more xfail --- .../device_architecture_comparison_on_device_aot.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp b/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp index 10dcf2f5b528f..a7531dcdf70bf 100644 --- a/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp +++ b/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp @@ -1,5 +1,8 @@ // REQUIRES: arch-intel_gpu_pvc, ocloc +// XFAIL: arch-intel_gpu_pvc && !igc-dev +// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 + // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_pvc %s -o %t.out // RUN: %{run} %t.out From c5c4dc76d28607743fef124a8874cd4e3bc19158 Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 17 Dec 2024 15:19:47 -0800 Subject: [PATCH 20/26] XFAIL device_architecture_comparison_on_device_aot.cpp on IGC as well. --- .../device_architecture_comparison_on_device_aot.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp b/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp index a7531dcdf70bf..88f55d00aa903 100644 --- a/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp +++ b/sycl/test-e2e/DeviceArchitecture/device_architecture_comparison_on_device_aot.cpp @@ -1,6 +1,6 @@ // REQUIRES: arch-intel_gpu_pvc, ocloc -// XFAIL: arch-intel_gpu_pvc && !igc-dev +// XFAIL: arch-intel_gpu_pvc // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 // RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_pvc %s -o %t.out From 0527d8718f1939b0d94ca6bbb6fa777b4f2a1291 Mon Sep 17 00:00:00 2001 From: Udit Kumar Agarwal Date: Wed, 18 Dec 2024 09:38:27 -0800 Subject: [PATCH 21/26] Use Ubuntu 24 docker image for IGC --- .github/workflows/sycl-post-commit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index fc69f39fcb888..9f44f5c529db0 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -68,7 +68,7 @@ jobs: extra_lit_opts: -j 100 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' - image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:devigc + image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu use_igc_dev: true From ed4ed37f2cc33802c27c3c1f21c693ced73bcc4e Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Wed, 18 Dec 2024 09:59:58 -0800 Subject: [PATCH 22/26] Remove XFAILs after updating IGC docker container --- sycl/test-e2e/Basic/accessor/accessor.cpp | 3 --- sycl/test-e2e/ESIMD/accessor_local.cpp | 2 +- sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp | 2 +- sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp | 2 +- .../test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp | 2 +- .../test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp | 3 --- .../Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp | 3 --- 7 files changed, 4 insertions(+), 13 deletions(-) diff --git a/sycl/test-e2e/Basic/accessor/accessor.cpp b/sycl/test-e2e/Basic/accessor/accessor.cpp index a84afdd46c24c..de944ba12754a 100644 --- a/sycl/test-e2e/Basic/accessor/accessor.cpp +++ b/sycl/test-e2e/Basic/accessor/accessor.cpp @@ -1,9 +1,6 @@ // RUN: %{build} -DSYCL2020_DISABLE_DEPRECATION_WARNINGS -o %t.out // RUN: %{run} %t.out -// XFAIL: arch-intel_gpu_pvc && igc-dev -// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 - //==----------------accessor.cpp - SYCL accessor basic test ----------------==// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. diff --git a/sycl/test-e2e/ESIMD/accessor_local.cpp b/sycl/test-e2e/ESIMD/accessor_local.cpp index bb6847d903919..21382f8ee401c 100644 --- a/sycl/test-e2e/ESIMD/accessor_local.cpp +++ b/sycl/test-e2e/ESIMD/accessor_local.cpp @@ -1,5 +1,5 @@ // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev && gpu-intel-dg2 +// XFAIL: igc-dev // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp b/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp index e1cb2ed7f51f3..ce8b4d30d0928 100644 --- a/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp +++ b/sycl/test-e2e/ESIMD/local_accessor_block_load_store.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev && gpu-intel-dg2 +// XFAIL: igc-dev // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp b/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp index 179ae3d118acc..c63411b286b32 100644 --- a/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp +++ b/sycl/test-e2e/ESIMD/local_accessor_copy_to_from.cpp @@ -6,7 +6,7 @@ // //===----------------------------------------------------------------------===// // REQUIRES-INTEL-DRIVER: lin: 27202, win: 101.4677 -// XFAIL: igc-dev && gpu-intel-dg2 +// XFAIL: igc-dev // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp b/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp index f180dff3e8a8c..790b7dc2a92da 100644 --- a/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp +++ b/sycl/test-e2e/ESIMD/lsc/lsc_local_accessor_block_load_store.cpp @@ -7,7 +7,7 @@ //===----------------------------------------------------------------------===// // REQUIRES: arch-intel_gpu_pvc || gpu-intel-dg2 // REQUIRES-INTEL-DRIVER: lin: 26690, win: 101.4576 -// XFAIL: igc-dev && gpu-intel-dg2 +// XFAIL: igc-dev // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16388 // RUN: %{build} -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp index e5335729a7d4d..febb1230d91dd 100644 --- a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp +++ b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_arg_dim.cpp @@ -17,8 +17,5 @@ // XFAIL: !igc-dev || gpu-intel-dg2 // XFAIL-TRACKER: CMPLRLLVM-63710 -// XFAIL: arch-intel_gpu_pvc && igc-dev -// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 - #include "common.hpp" #include "joint_matrix_bf16_fill_k_cache_impl.hpp" diff --git a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp index d522301d3296c..291852eaa612d 100644 --- a/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp +++ b/sycl/test-e2e/Matrix/joint_matrix_bf16_fill_k_cache_runtime_dim.cpp @@ -17,8 +17,5 @@ // XFAIL: !igc-dev || gpu-intel-dg2 // XFAIL-TRACKER: CMPLRLLVM-63710 -// XFAIL: arch-intel_gpu_pvc && igc-dev -// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 - #include "common.hpp" #include "joint_matrix_bf16_fill_k_cache_impl.hpp" From 7ff2604f968b5e60d9733ed52fa7e00fd38f06f4 Mon Sep 17 00:00:00 2001 From: Udit Kumar Agarwal Date: Fri, 20 Dec 2024 08:28:56 -0800 Subject: [PATCH 23/26] Use Ubuntu 24.04 container for IGC release --- .github/workflows/sycl-post-commit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index 9f44f5c529db0..a179ab1925006 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -62,7 +62,7 @@ jobs: reset_intel_gpu: false - name: E2E tests on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' - image: ghcr.io/intel/llvm/ubuntu2204_intel_drivers:latest + image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:latest image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu extra_lit_opts: -j 100 From 2a8567a975f8e0eb2ea95434a2e6bbc554beec9c Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Mon, 23 Dec 2024 14:51:39 -0800 Subject: [PATCH 24/26] Add XFAIL to more tests --- sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp | 3 --- .../out-of-bounds/DeviceGlobal/device_global.cpp | 4 ++++ sycl/test-e2e/Basic/accessor/accessor.cpp | 4 ++++ sycl/test-e2e/MemorySanitizer/lit.local.cfg | 7 ++++--- sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp | 2 +- sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp | 2 +- 6 files changed, 14 insertions(+), 8 deletions(-) diff --git a/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp b/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp index 88d9e36065e5a..b7dc64c3c3de8 100644 --- a/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp +++ b/sycl/test-e2e/AddressSanitizer/common/kernel-filter.cpp @@ -4,9 +4,6 @@ // RUN: %{build} %device_asan_aot_flags -O2 -fsanitize-ignorelist=%p/ignorelist.txt -o %t2 // RUN: %{run} %t2 2>&1 | FileCheck %s -// XFAIL: arch-intel_gpu_pvc -// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16401 - #include #include diff --git a/sycl/test-e2e/AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp b/sycl/test-e2e/AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp index 36c66562c08f4..94325a52eb7fa 100644 --- a/sycl/test-e2e/AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp +++ b/sycl/test-e2e/AddressSanitizer/out-of-bounds/DeviceGlobal/device_global.cpp @@ -6,6 +6,10 @@ // RUN: %{build} %device_asan_flags -O2 -g -o %t3.out // RUN: %{run} not %t3.out 2>&1 | FileCheck %s +// Flakily timesout on PVC +// UNSUPPORTED: arch-intel_gpu_pvc +// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/16401 + #include #include diff --git a/sycl/test-e2e/Basic/accessor/accessor.cpp b/sycl/test-e2e/Basic/accessor/accessor.cpp index de944ba12754a..f51bf53173a82 100644 --- a/sycl/test-e2e/Basic/accessor/accessor.cpp +++ b/sycl/test-e2e/Basic/accessor/accessor.cpp @@ -1,6 +1,10 @@ // RUN: %{build} -DSYCL2020_DISABLE_DEPRECATION_WARNINGS -o %t.out // RUN: %{run} %t.out +// Test flakily fails on PVC. +// UNSUPPORTED: arch-intel_gpu_pvc +// UNSUPPORTED-TRACKER: https://github.com/intel/llvm/issues/16401 + //==----------------accessor.cpp - SYCL accessor basic test ----------------==// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. diff --git a/sycl/test-e2e/MemorySanitizer/lit.local.cfg b/sycl/test-e2e/MemorySanitizer/lit.local.cfg index f83bb4e4de89d..f9437ee4a9048 100644 --- a/sycl/test-e2e/MemorySanitizer/lit.local.cfg +++ b/sycl/test-e2e/MemorySanitizer/lit.local.cfg @@ -1,7 +1,8 @@ # TRACKER: https://github.com/intel/llvm/issues/16184 -has_arch_gpu_intel_pvc = any('arch-intel_gpu_pvc' in T for T in config.sycl_dev_features.values()) -if not has_arch_gpu_intel_pvc: - config.unsupported_features += ['gpu'] +# TRACKER for PVC: https://github.com/intel/llvm/issues/16401 +#has_arch_gpu_intel_pvc = any('arch-intel_gpu_pvc' in T for T in config.sycl_dev_features.values()) +#if not has_arch_gpu_intel_pvc: +config.unsupported_features += ['gpu'] config.substitutions.append( ("%device_msan_flags", "-Xarch_device -fsanitize=memory") diff --git a/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp b/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp index 4de91a66941aa..2bf285b0ee609 100644 --- a/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp +++ b/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp @@ -1,5 +1,5 @@ // REQUIRES: level_zero, level_zero_dev_kit, cm-compiler -// XFAIL: gpu +// XFAIL: gpu && !arch-intel_gpu_pvc || !igc-dev // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16406 // RUN: %{build} -Wno-error=deprecated-declarations -DRUN_KERNELS %level_zero_options -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp b/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp index b0023426f0631..ec3a56dc572ae 100644 --- a/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp +++ b/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp @@ -1,5 +1,5 @@ // REQUIRES: opencl, opencl_icd, cm-compiler -// XFAIL: gpu || cpu || accelerator +// XFAIL: !arch-intel_gpu_pvc || !igc-dev // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16406 // RUN: %{build} -Wno-error=deprecated-declarations -DRUN_KERNELS %opencl_lib -o %t.out // RUN: %{run} %t.out From daf8037a99dd6028377f9b33e697c2c6fa2281bc Mon Sep 17 00:00:00 2001 From: "Agarwal, Udit" Date: Tue, 24 Dec 2024 08:02:16 -0800 Subject: [PATCH 25/26] Fix XFAILs on OnlineCOmpiler tests. Skip ESIMD?unified_memory_api tests on PVC --- .github/workflows/sycl-post-commit.yml | 2 ++ sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp | 2 +- sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index 11afab4335334..2e96abae06f46 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -62,12 +62,14 @@ jobs: reset_intel_gpu: false - name: E2E tests on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' + env: '{"LIT_FILTER_OUT":"ESIMD/unified_memory_api/"}' image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:latest image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu extra_lit_opts: -j 100 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' + env: '{"LIT_FILTER_OUT":"ESIMD/unified_memory_api/"}' image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:devigc image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu diff --git a/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp b/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp index 2bf285b0ee609..0d80e37e7d9fc 100644 --- a/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp +++ b/sycl/test-e2e/OnlineCompiler/online_compiler_L0.cpp @@ -1,5 +1,5 @@ // REQUIRES: level_zero, level_zero_dev_kit, cm-compiler -// XFAIL: gpu && !arch-intel_gpu_pvc || !igc-dev +// XFAIL: gpu && !(arch-intel_gpu_pvc && igc-dev) // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16406 // RUN: %{build} -Wno-error=deprecated-declarations -DRUN_KERNELS %level_zero_options -o %t.out // RUN: %{run} %t.out diff --git a/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp b/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp index ec3a56dc572ae..360592289a969 100644 --- a/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp +++ b/sycl/test-e2e/OnlineCompiler/online_compiler_OpenCL.cpp @@ -1,5 +1,5 @@ // REQUIRES: opencl, opencl_icd, cm-compiler -// XFAIL: !arch-intel_gpu_pvc || !igc-dev +// XFAIL: (gpu && !(arch-intel_gpu_pvc && igc-dev)) || cpu || accelerator // XFAIL-TRACKER: https://github.com/intel/llvm/issues/16406 // RUN: %{build} -Wno-error=deprecated-declarations -DRUN_KERNELS %opencl_lib -o %t.out // RUN: %{run} %t.out From e1e946af75eeea67cabbc6ad763e45ae5aa62e2f Mon Sep 17 00:00:00 2001 From: Udit Kumar Agarwal Date: Tue, 24 Dec 2024 08:45:28 -0800 Subject: [PATCH 26/26] Reduce number of parallel jobs --- .github/workflows/sycl-post-commit.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-post-commit.yml b/.github/workflows/sycl-post-commit.yml index 2e96abae06f46..816cb313a1284 100644 --- a/.github/workflows/sycl-post-commit.yml +++ b/.github/workflows/sycl-post-commit.yml @@ -66,7 +66,7 @@ jobs: image: ghcr.io/intel/llvm/ubuntu2404_intel_drivers:latest image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu - extra_lit_opts: -j 100 + extra_lit_opts: -j 50 - name: E2E tests with dev igc on Intel Ponte Vecchio GPU runner: '["Linux", "pvc"]' env: '{"LIT_FILTER_OUT":"ESIMD/unified_memory_api/"}' @@ -74,7 +74,7 @@ jobs: image_options: -u 1001 --device=/dev/dri --privileged --cap-add SYS_ADMIN target_devices: ext_oneapi_level_zero:gpu;opencl:gpu use_igc_dev: true - extra_lit_opts: -j 100 + extra_lit_opts: -j 50 # Performance tests below. Specifics: # - only run performance tests (use LIT_FILTER env) # - ask llvm-lit to show all the output, even for PASS (-a)