Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

extend, document and test metrics support #666

Closed
pohly opened this issue Jun 4, 2020 · 4 comments
Closed

extend, document and test metrics support #666

pohly opened this issue Jun 4, 2020 · 4 comments
Assignees
Labels
0.8 needs to be fixed in 0.8.x

Comments

@pohly
Copy link
Contributor

pohly commented Jun 4, 2020

We already have a metrics service for the controller in our deployment, but so far we are mostly just using it internally during testing to verify that the driver is ready. We also get metrics support from the Kubernetes-CSI sidecars

We should

  • check what other information besides "version" and "number of nodes" may be useful
  • enable metrics support in the sidecar deployments
  • document how metrics support works, including an example for gathering it with tools like Prometheus
  • last but not least, add more tests to test/e2e/metrics
@pohly pohly added the future needs to be fixed in some future release label Jun 4, 2020
@pohly pohly added 0.8 needs to be fixed in 0.8.x and removed future needs to be fixed in some future release labels Jun 18, 2020
@pohly
Copy link
Contributor Author

pohly commented Jun 18, 2020

Let's target for 0.8.x as part of making PMEM-CSI more admin-friendly.

@pohly pohly self-assigned this Jun 18, 2020
@pohly
Copy link
Contributor Author

pohly commented Jun 19, 2020

enable metrics support in the sidecar deployments

Upstream is tracking documentation efforts for that in kubernetes-csi/docs#339 after I asked how to use this.

While trying to enable it, I ran into prometheus/prometheus#3756 which IMHO prevents scraping the sidecar metrics. I tried the approach of merging in their data, but because some of it is the same in all processes (like process_open_fds or go_gc_duration_seconds), that doesn't work properly. Code is in https://github.com/pohly/pmem-CSI/commits/sidecar-metrics

@pohly
Copy link
Contributor Author

pohly commented Jun 22, 2020

This approach is more promising: https://github.com/pohly/pmem-CSI/commits/metrics-enhancements

@pohly
Copy link
Contributor Author

pohly commented Sep 29, 2020

Done in PR #715

@pohly pohly closed this as completed Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.8 needs to be fixed in 0.8.x
Projects
None yet
Development

No branches or pull requests

1 participant