feat: add Expo example app and align runtime with react-native 0.76.5 #4
Conversation
apps/example/.gitignore
Outdated
| *.pem | ||
|
|
||
| # local env files | ||
| .env*.local |
There was a problem hiding this comment.
I wonder if it could be .env* to ignore any env file, not only the local ones.
is there any scenario when someone wants to commit .env?
There was a problem hiding this comment.
I don't know yet, but we've committed.env.mainnet, etc. at the root.
I guess I'll ignore all env files for now as we're going to modify secrets handling and I'd prefer to avoid unintentionally leaking them.
apps/example/app.json
Outdated
| "name": "Example", | ||
| "slug": "example", |
There was a problem hiding this comment.
shall we add "MobileStack" somewhere here? to emphasize what this example is for
There was a problem hiding this comment.
yes why not, we can just use MobileStack.
| <Provider store={store}> | ||
| <FiatConnectReviewScreen {...mockProps} /> | ||
| </Provider> | ||
| ) | ||
|
|
||
| expect((await findByTestId('expiredQuoteDialog')).props.visible).toEqual(false) | ||
| expect(queryByTestId('expiredQuoteDialog')).toBeFalsy() |
There was a problem hiding this comment.
I'm a bit confused by the await we had previously.
like it waits for something which causes the expired quote dialog to render (or not to).
if this assumption is true, without waiting it may be always falsy.
perhaps we can move this case below the timer advance to be sure we waited?
There was a problem hiding this comment.
I can try, but the difference is those dialogs are now not rendered at all until visible.
There was a problem hiding this comment.
ok moving it after the timer advance still works.
Description
This PR introduces an example app using Expo, generated with the following command:
While setting up this app, compatibility issues arose between Expo's use of
[email protected]and our runtime's use of[email protected]. These were resolved by:Moving the runtime's native dependencies to
peerDependencies:Adding root resolutions:
react-nativeand related dependencies is used.Additionally, changes were made to the runtime tests due to differences in how the
<Modal />component renders in tests with the newreact-nativeversion. Specifically,<Modal />now renders asnullwhen not visible.Note: the example app doesn't yet consume the runtime, see #6 for that.
Part of RET-1279