-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company monthly_spend is an int instead of decimal #117
Comments
The Intercom API only supports integer values in |
What is the correct way to map an amount with cents like 1.95 in that case, or is it not possible? |
As far as I know, that would have to be stored in a custom attribute: decimal monthlyFees = 1.95;
company.custom_attributes["monthly_fees"] = monthlyFees; In the Intercom app, you can then leverage that attribute in pretty much the same way in terms of filtering, qualification, etc. |
Hey @xdansmith, thank you for bringing this up. Not quite sure which is the expected behaviour and this week I am away from any work on the API, but early next week I'll do some testing and ensure we match the type that the API accepts from curl for full feature parity. 👍 |
I checked with the team and it seems that we accept Floats: However they will be truncated. I made this change already, would it be possible to get a review? #129 |
Can monthly_spend be changed back to a decimal so accurate monthly fees can be stored, like
1.95
?The text was updated successfully, but these errors were encountered: