Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 2.1.1 does not target .NET Standard #156

Open
martinmasse opened this issue Aug 19, 2019 · 10 comments
Open

Latest version 2.1.1 does not target .NET Standard #156

martinmasse opened this issue Aug 19, 2019 · 10 comments

Comments

@martinmasse
Copy link

Hi,

It seems that we have lost the .NET Standard target in the latest release making it not compatible with .NET Core

@mscrivo
Copy link

mscrivo commented Sep 5, 2019

yeah, this seems like a pretty bad regression.

@hognevevle
Copy link

Any ETA for a fixed package?

@ThomasArdal
Copy link
Contributor

This is keeping me from updating as well.

@gonace
Copy link

gonace commented Feb 7, 2020

Same here, would be great to get a "fix" for this 👍

@johnnyoshika
Copy link

Is this still an actively supported SDK?

@AndiRudi
Copy link

AndiRudi commented Apr 2, 2020

Hello we are also stuck in our migration for .net core. NETStandard is vital to move towards .net core.

@AndiRudi
Copy link

AndiRudi commented Apr 2, 2020

Someone made #157 which should solve the issue

@mngobbi
Copy link

mngobbi commented Jan 23, 2021

Maybe #166 could help with this? Fixes that CircleCI build error too....

@mgoodfellow
Copy link

It looks like Intercom have completely dropped support for this library which is a real shame considering the cost of their product, and considering that the community have attempted to provide PRs to fix these issues but which are seemingly ignored. This project should be marked as deprecated.

A few options - fork it, and issue nugets from the patched PRs, or alternatively you can use 2.1.0 (https://github.com/intercom/intercom-dotnet/releases/tag/2.1.0) which does support netcore, but you will still be on the old v1.2 API (and who knows how long that will be supported for!) - #163

Internally we have just setup a refit (https://github.com/reactiveui/refit) interface around some of their endpoints as needed, and define our own data models. Saves being bound to an unsupported and out of date library.

@ThomasArdal
Copy link
Contributor

For future visitors and in addition to @mgoodfellow's comments, I'm using the 2.1.0 package with version 1.4 of Intercom's API. I haven't experienced anything that isn't working yet, but there could be something unsupported with that combination. Any newer versions of the API won't work with 2.1.0.

I can only agree with everything here. It's a shame that Intercom offers this package and then don't maintain it. Deprecate it or fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants