Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix coinbase parsing for low heights #1139

Merged

Conversation

sander2
Copy link
Member

@sander2 sander2 commented Jul 24, 2023

The code was reading three bytes, regardless of how many bytes the height actually consisted of. On mainnet this is fine, but it broke regtest & simulator tests because these heights were encoded using fewer bytes

@gregdhill gregdhill merged commit ac05c24 into interlay:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants