[BREAKING] feat!: shared public key #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sander2
commented
Apr 11, 2022
gregdhill
reviewed
Apr 12, 2022
gregdhill
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the bitcoin public key is shared among all vaultids that share the same accountid.
Prior to calling
register_vault, the vault must callupdate_public_key, which sets the public key in the newVaultBitcoinPublicKeymap.A note to downstream: the
UpdatePublicKeyevent type has changed, as well as theregister_vaultandupdate_public_keyfunctions.Note to reviewer: this PR is neatly split up into separate commits which may be useful in reviewing. Please also check the migration carefully.