Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor / remove Assets associated type from loans pallet #864

Closed
daniel-savu opened this issue Jan 18, 2023 · 0 comments · Fixed by #885
Closed

Refactor / remove Assets associated type from loans pallet #864

daniel-savu opened this issue Jan 18, 2023 · 0 comments · Fixed by #885
Labels
enhancement New feature or request
Milestone
Lend / Borrow

Comments

@daniel-savu
Copy link
Contributor

The loans pallet is tightly coupled with the currency pallet but also takes Tokens ( orml-tokens) as an associated type, which is unnecessary and confusing. Remove the associated Assets type from the pallet if possible.
@daniel-savu daniel-savu added the enhancement New feature or request label Jan 18, 2023
@daniel-savu daniel-savu added this to the Lend / Borrow milestone Jan 18, 2023
@nud3l nud3l added this to Backlog Jan 18, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Jan 18, 2023
@nud3l nud3l moved this from New 🆕 to Todo ⏳ in Backlog Jan 24, 2023
@daniel-savu daniel-savu mentioned this issue Jan 24, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo ⏳ to Done ✅ in Backlog Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Backlog
Archived in project
Milestone
Lend / Borrow
Development

Successfully merging a pull request may close this issue.

Remove Assets config type from Loans pallet daniel-savu/interbtc
1 participant
@daniel-savu