feat: add zenlink rpcs to parachain service #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregdhill
force-pushed
the
feat/zenlink-rpc
branch
3 times, most recently
from
89bfb20 to
00a09b1
Compare
Signed-off-by: Gregory Hill <[email protected]>
gregdhill
force-pushed
the
feat/zenlink-rpc
branch
from
00a09b1 to
0c02495
Compare
sander2
reviewed
Jan 24, 2023
| @@ -1617,4 +1617,109 @@ impl_runtime_apis! { | |||
| .and_then(|liquidity| liquidity.to_rpc_tuple()) | |||
| } | |||
| } | |||
|
|
|||
| impl zenlink_protocol_runtime_api::ZenlinkProtocolApi<Block, AccountId, CurrencyId> for Runtime { | |||
There was a problem hiding this comment.
Why add these rpcs to standalone if they don't have an actual implementation?
There was a problem hiding this comment.
Because the rpc crate requires those runtime APIs and since we anyway plan to deprecate standalone I didn't want to add the actual Zenlink code there.
sander2
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gregory Hill [email protected]
Exposes all Zenlink RPCs on the parachain node.
Bumped the Zenlink dependencies to use a newer version of
jsonrpsee.Renamed Zenlink stable pallet ID from
bf/stammtostbl/amm- will need manual migration for existing pools.