Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loans: redeem not releasing correct amount due to rounding #929

Closed
sander2 opened this issue Feb 13, 2023 · 0 comments · Fixed by #930
Closed

Loans: redeem not releasing correct amount due to rounding #929

sander2 opened this issue Feb 13, 2023 · 0 comments · Fixed by #930
Labels
bug Something isn't working

Comments

@sander2
Copy link
Member

sander2 commented Feb 13, 2023

In both redeem, the underlying amount is first converted to the lend token amount, after which the to-be released collateral is calculated by converting the lend token back to the underlying amount. This can have the consequence that the released collateral is less than what was requested in the redeem call. We should refactor to avoid the second conversion

@sander2 sander2 added the bug Something isn't working label Feb 13, 2023
@nud3l nud3l added this to Backlog Feb 13, 2023
@github-project-automation github-project-automation bot moved this to New 🆕 in Backlog Feb 13, 2023
@github-project-automation github-project-automation bot moved this from New 🆕 to Done ✅ in Backlog Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant