Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate GNAP requests with OpenAPI #351

Closed
njlie opened this issue Jun 1, 2022 · 1 comment · Fixed by #384 or #821
Closed

Validate GNAP requests with OpenAPI #351

njlie opened this issue Jun 1, 2022 · 1 comment · Fixed by #384 or #821
Assignees
@sabineschaller @njlie
Milestone
GNAP AS

Comments

@njlie
Copy link
Contributor

njlie commented Jun 1, 2022 •
edited
Loading

From #343 (comment):

🤔 Maybe this OpenAPI validation middleware (#339) could be a workspace in the monorepo: https://github.com/interledger/rafiki/tree/bw-openapi/packages/backend/src/openapi Then this could validate requests based on https://github.com/interledger/open-payments/blob/master/auth-server-open-api-spec.yaml

See:
4556d21
@njlie njlie added this to the GNAP AS milestone Jun 1, 2022
@njlie njlie mentioned this issue Jun 1, 2022
Merged
4 tasks
@sabineschaller sabineschaller self-assigned this Jun 27, 2022
@sabineschaller sabineschaller moved this to In Progress in Rafiki Jun 27, 2022
@sabineschaller sabineschaller mentioned this issue Jun 28, 2022
Merged
4 tasks
Repository owner moved this from In Progress to Done in Rafiki Jun 30, 2022
@wilsonianb wilsonianb mentioned this issue Sep 8, 2022
Merged
4 tasks
@wilsonianb wilsonianb mentioned this issue Sep 20, 2022
Merged
4 tasks
@sabineschaller
Copy link
Member

Reopened to specify the ctx.body type in createGrantInitiation and elsewhere to make use of the benefits of the OpenAPI validator middleware type guard.
See comment

@njlie njlie self-assigned this Nov 30, 2022
@njlie njlie mentioned this issue Dec 5, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sabineschaller sabineschaller

@njlie njlie

Labels
None yet
Projects
No open projects
Rafiki
Status: Done
Milestone
GNAP AS
2 participants
@sabineschaller @njlie