Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shortcut to focus search #212

Closed
4www opened this issue Mar 25, 2018 · 10 comments · Fixed by #402
Closed

Add shortcut to focus search #212

4www opened this issue Mar 25, 2018 · 10 comments · Fixed by #402

Comments

@4www
Copy link
Contributor

4www commented Mar 25, 2018

s, when on should be the shortcut to focus the search input.

on:

  • radio4000.com/all
  • radio4000.com/acapulco

Note:
Of we ever implement Algolia's search on /all or on a more global route, the s shortcut feature could target this the new algolia search input. Question then araises when on a /$channel{/,tracks} route, which input (if there are two, one global and one for this channel tracks) does s focuses? Maybe we can answer later to this.

@oskarrough
Copy link
Member

You mean instead of shift+s like now?

If we get a global, channel search we could split it:

  • s = primary, global search (channels)
  • shift+s = secondary, contextual search (tracks)

Another note: it's a bit confusing that g+s takes you to favorites and not /search.

@4www
Copy link
Contributor Author

4www commented Mar 26, 2018

But there is no /search?

g + s = go starred, aka the channels you added a star to favorite.

Totally forgot about the S shortcut (shift + s). Also we should therefore add it to /all where it is not implemented.

@oskarrough
Copy link
Member

There is search here https://radio4000.com/search. But perhaps this is an indication that it should be renamed again.

@oskarrough
Copy link
Member

Totally forgot about the S shortcut (shift + s). Also we should therefore add it to /all where it is not implemented.

Yea, let's do that? I just remembered that we moved it from s to shift+s to avoid a conflict with the shuffle shortcut.

e5cd988

@oskarrough
Copy link
Member

oskarrough commented Jun 8, 2018

Or a combination of forward slash / and s like on github.com.

@4www
Copy link
Contributor Author

4www commented Oct 18, 2018

I think we could start by adding the focus search shift + s (S) feature like on the /tracks page, to:

@oskarrough
Copy link
Member

so when you're on one of those pages, shift+s focuses the search input? go for it!

@4www 4www mentioned this issue Jan 16, 2019
@oskarrough
Copy link
Member

This can be closed now? You focus search with / forward slash /cc @hugurp

@4www
Copy link
Contributor Author

4www commented Feb 5, 2019

no the same thing,/ focus the quick jump, not the search input on /explore

@oskarrough
Copy link
Member

Ah ok! So how to proceed…

Should we add shift + s for the "contextual search"? Another keybind?
For instance on /explore or /followers (once we get search there, too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants