We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have eslint linting for our JS. Let's add a rule for no-undef for consistency.
Define the environment in .eslintrc.json:
"env": { "browser": true, "jquery": true },
Make sure all other undefined variables are accounted for (see below)
// startTime is defined inside openlibrary/plugins/openlibrary/js/ol.js // eslint-disable-next-line no-undef 'loadtime':(endTime.getTime() - startTime.getTime()),
The text was updated successfully, but these errors were encountered:
I'm going to take a look at this
Sorry, something went wrong.
I've opened a PR for this and would love your feedback.
Successfully merging a pull request may close this issue.
We have eslint linting for our JS. Let's add a rule for no-undef for consistency.
Define the environment in .eslintrc.json:
Make sure all other undefined variables are accounted for (see below)
Checklist
e.g.
The text was updated successfully, but these errors were encountered: