Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upset plot #14

Open
jhawkey opened this issue Jan 24, 2025 · 2 comments
Open

upset plot #14

jhawkey opened this issue Jan 24, 2025 · 2 comments

Comments

@jhawkey
Copy link
Contributor

jhawkey commented Jan 24, 2025

Draft version currently implemented. Would be nice to add the following features:

  • plotting of S/I/R colours (currently just R or NWT)
  • handling of disk column instead of mic
  • fixing broken implementation of plotting guidelines - current code doesn't work because it requires ab and mo values, which are not present in the binary matrix. Possible fixes would be getting the user to define the abs and organism in the function call?
@jhawkey
Copy link
Contributor Author

jhawkey commented Jan 31, 2025

latest version now plots S/I/R colours and should be able to handle disk.

However still can't plot guidelines, but I think because of issues with scale_y_mic(). If a breakpoint value is 0.064 (for example), but the scale lists only 0.06, then this line is not plotted as 0.064 isn't one of the discrete mic values.

Also having issues naming the y axis of the upset plot as either 'MIC' or 'disk', as this will depend on user input. Currently y_axis_name is a string being stored in a variable, but the string inside this variable isn't being printed on the plot

@katholt
Copy link
Contributor

katholt commented Jan 31, 2025

Just noting for clarity these comments relate to the function amr_complexUpset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants