Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Tickf optimization #3375

Merged
merged 4 commits into from
Apr 8, 2023
Merged

Revert Tickf optimization #3375

merged 4 commits into from
Apr 8, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Apr 8, 2023

Description

This PR disables both of the optimizations implemented in #3209 Current implementation is causing problems. Reasons are not yet known and require investigation. That is why this PR only disables the optimizations instead of reverting them completely.

Important to note that both of the optimizations are causing problems, even when applied separately:

  • lazy computation of pool stake distribution
  • and minimizing logic in TICKF rule

That is why they are both being disabled.

Naturally, as all of my PRs go, this one also has a little bit of a cleanup included in it as a separate commit.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the CHANGELOG.md for affected package
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins force-pushed the lehins/tickf-experiment branch from 8ba2a68 to c05a740 Compare April 8, 2023 00:41
@lehins lehins enabled auto-merge April 8, 2023 00:52
@lehins lehins disabled auto-merge April 8, 2023 00:53
@lehins lehins enabled auto-merge April 8, 2023 00:55
@lehins lehins merged commit 36cae52 into master Apr 8, 2023
@iohk-bors iohk-bors bot deleted the lehins/tickf-experiment branch April 8, 2023 02:35
@lehins lehins mentioned this pull request Apr 26, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants