Restructure the namespace #4117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jutaro
force-pushed
the
jutaro/restructure-namespace
branch
from
17fd953 to
e3f1fcc
Compare
jutaro
requested review from
Jimbo4350,
newhoggy,
denisshevchenko,
coot and
mgmeier
as code owners
deepfire
force-pushed
the
jutaro/restructure-namespace
branch
from
6c929b5 to
10558d0
Compare
denisshevchenko
approved these changes
Jul 7, 2022
| , IntM "rts.mutticks" (fromIntegral $ rCentiMut rs) | ||
| , IntM "rts.stat.threads" (fromIntegral $ rThreads rs) | ||
| [ IntM "Resources.Stat.Cputicks" (fromIntegral $ rCentiCpu rs) | ||
| , IntM "Resources.mem.Resident" (fromIntegral $ rRSS rs) |
There was a problem hiding this comment.
@jutaro Is it "Resources.mem.Resident" and not "Resources.Mem.Resident"?
There was a problem hiding this comment.
Should be: Resources.Mem.Resident
deepfire
approved these changes
Jul 7, 2022
|
This is great -- thank you @jutaro ! |
deepfire
force-pushed
the
jutaro/restructure-namespace
branch
from
fdbd963 to
2454216
Compare
deepfire
force-pushed
the
jutaro/restructure-namespace
branch
2 times, most recently
from
b21b4fc to
d6ebd0e
Compare
jutaro
force-pushed
the
jutaro/restructure-namespace
branch
from
d6ebd0e to
3787011
Compare
Jimbo4350
approved these changes
Jul 8, 2022
|
bors merge |
newhoggy
reviewed
Jul 8, 2022
| "Tell the consumer to extend their chain with the given header.\ | ||
| \\n\ | ||
| "Tell the consumer to extend their chain with the given header. \ | ||
| \\n \ |
There was a problem hiding this comment.
Is the space after the newline intentional?
newhoggy
reviewed
Jul 8, 2022
| "Request one or more transactions corresponding to the given \ | ||
| \transaction identifiers. \ | ||
| \\n\ | ||
| "Request one or more transactions corresponding to the given \ |
There was a problem hiding this comment.
Is the double space intentional?
newhoggy
reviewed
Jul 8, 2022
| The message also tells the consumer about the head point of the producer. | ||
| *** | ||
| > Tell the consumer to extend their chain with the given header. | ||
| > The message also tells the consumer about the head point of the producer. |
There was a problem hiding this comment.
Is this indentation intentional?
newhoggy
reviewed
Jul 8, 2022
|
|
||
| *** | ||
| > We forged a block. | ||
| > We record the current slot number, the point of the predecessor, the block itself, and the total size of the mempool snapshot at the time we produced the block (which may be significantly larger than the block, due to maximum block size) |
There was a problem hiding this comment.
Can see the double space manifest in this text. Is this intentional?
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure the namespace of trace messages to get some logic into it.