Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cardano-node: provide default node name #4366

Merged
merged 1 commit into from
Aug 24, 2022
Merged

cardano-node: provide default node name #4366

merged 1 commit into from
Aug 24, 2022

Conversation

denisshevchenko
Copy link
Contributor

Closes #4364

@denisshevchenko denisshevchenko added bug Something isn't working RTView The service for monitoring over Cardano nodes cardano-node labels Aug 20, 2022
@denisshevchenko denisshevchenko self-assigned this Aug 20, 2022
deepfire
deepfire approved these changes Aug 20, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xie xie, Denis!

@deepfire deepfire force-pushed the bug-4364-node-name branch from 1dda4a6 to edff421 Compare August 24, 2022 04:25
@deepfire deepfire force-pushed the bug-4364-node-name branch from edff421 to 9f28213 Compare August 24, 2022 04:25
@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 24, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit e409603 into master Aug 24, 2022
@iohk-bors iohk-bors bot deleted the bug-4364-node-name branch August 24, 2022 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@coot coot coot left review comments

@newhoggy newhoggy newhoggy approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@jutaro jutaro Awaiting requested review from jutaro

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

Assignees

@denisshevchenko denisshevchenko

Labels
bug Something isn't working cardano-node RTView The service for monitoring over Cardano nodes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RTView: localhost nodes log mis-coalescence
4 participants
@denisshevchenko @deepfire @newhoggy @coot