Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cicero CI actions #4489

Merged
merged 1 commit into from
Nov 2, 2022
Merged

add cicero CI actions #4489

merged 1 commit into from
Nov 2, 2022

Conversation

dermetfan
Copy link
Contributor

@dermetfan dermetfan commented Sep 27, 2022

This adds a tullia task for every hydra job and cicero actions that run them for every push and PR.

Edit: There's only one tullia task now that builds everything.

@dermetfan dermetfan force-pushed the cicero branch 2 times, most recently from 0f8ed2e to e9e338b Compare September 27, 2022 19:46
@dermetfan dermetfan marked this pull request as ready for review September 27, 2022 19:47
@dermetfan dermetfan marked this pull request as draft September 27, 2022 20:09
@dermetfan dermetfan force-pushed the cicero branch 2 times, most recently from 9f48cff to ea57a13 Compare September 27, 2022 20:14
@dermetfan dermetfan marked this pull request as ready for review September 27, 2022 20:18
nix/tullia.nix Show resolved Hide resolved
nix/tullia.nix Outdated Show resolved Hide resolved
nix/tullia.nix Outdated
Comment on lines 30 to 32
if config.actionRun.facts != {}
then with config.preset.github-ci; "github:${repo}/${sha}"
else "."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come having a fact means you can refer to the flake with .?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tullia tasks can be run locally or on Cicero. When no facts are present we know that we are running locally and vice versa. When running locally, the current directory is already bind-mounted into the container, so we don't need to fetch the source from GitHub.

nix/tullia.nix Outdated Show resolved Hide resolved
nix/tullia.nix Show resolved Hide resolved
@dermetfan dermetfan marked this pull request as draft September 29, 2022 15:54
@dermetfan dermetfan force-pushed the cicero branch 17 times, most recently from 95d249a to feaaa6c Compare September 30, 2022 14:20
@dermetfan dermetfan force-pushed the cicero branch 3 times, most recently from 60becc3 to 633f88f Compare October 4, 2022 13:10
@dermetfan dermetfan marked this pull request as ready for review October 4, 2022 13:36
@dermetfan dermetfan force-pushed the cicero branch 3 times, most recently from 5a2f74a to 991e182 Compare October 7, 2022 14:37
@dermetfan dermetfan requested a review from angerman October 11, 2022 08:38
@dermetfan dermetfan force-pushed the cicero branch 2 times, most recently from 6383c69 to 2125590 Compare October 14, 2022 15:42
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Oct 26, 2022

This adds a tullia task for every hydra job and cicero actions that run them for every push and PR.

@dermetfan can you show where the jobs are translated over? It's not clear to me.

@dermetfan
Copy link
Contributor Author

@Jimbo4350 Here: The flakeOutputTasks function generates a set of tullia tasks given an arbitrarily nested set that contains derivations.

@dermetfan dermetfan requested a review from a team as a code owner October 27, 2022 12:25
@dermetfan dermetfan force-pushed the cicero branch 7 times, most recently from 7490e62 to 7348613 Compare November 1, 2022 13:55
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add nix cache to flake config

add tullia flake input

add cardano-node/ci/{push,pr} cicero actions

generate one tullia task for each hydra job

run tullia tasks sequentially in CI actions

to reduce load at one time

also build os-agnostic hydra jobs

build everything in one task

instead of dynamically creating tasks for every hydra job
@disassembler
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 2, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit e0d6b16 into master Nov 2, 2022
@iohk-bors iohk-bors bot deleted the cicero branch November 2, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants