New p2p topology file format #4563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
requested review from
Jimbo4350,
newhoggy,
a team,
deepfire,
jutaro,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
coot
force-pushed
the
coot/p2p-topology
branch
3 times, most recently
from
8a8bc6e to
b4359f2
Compare
coot
force-pushed
the
coot/p2p-topology
branch
from
b4359f2 to
3bf21ce
Compare
Jimbo4350
requested changes
Oct 27, 2022
|
One last thing, can you add a |
bolt12
approved these changes
Oct 31, 2022
coot
force-pushed
the
coot/p2p-topology
branch
2 times, most recently
from
b53ff4d to
6fed2ae
Compare
|
@Jimbo4350 I added entry in the |
coot
force-pushed
the
coot/p2p-topology
branch
from
6fed2ae to
d0b1109
Compare
Jimbo4350
requested changes
Nov 2, 2022
coot
force-pushed
the
coot/p2p-topology
branch
2 times, most recently
from
8f1b7c4 to
d5e5835
Compare
Jimbo4350
approved these changes
Nov 4, 2022
|
bors merge |
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from input-output-hk/docs-access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Test p2p topology decoder by generating valid encodings.
coot
force-pushed
the
coot/p2p-topology
branch
from
d5e5835 to
24e1f6e
Compare
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Nov 8, 2022
4563: New p2p topology file format r=coot a=coot Fixes #4559. Co-authored-by: Marcin Szamotulski <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from input-output-hk/docs-access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
coot
commented
Nov 8, 2022
olgahryniuk
approved these changes
Nov 8, 2022
|
bors merge |
|
Build succeeded: |
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4559.