tx-generator: add capability for PlutusV2 scripts #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgmeier
requested review from
Jimbo4350,
newhoggy,
a team,
coot,
deepfire,
jutaro,
fmaste,
cleverca22,
dcoutts,
erikd,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
mgmeier
added
WIP
mgmeier
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
2 times, most recently
from
d375075 to
f7eda48
Compare
This was referenced Dec 8, 2022
mgmeier
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
2 times, most recently
from
456ec90 to
b075aa5
Compare
deepfire
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
from
b075aa5 to
90c3f17
Compare
deepfire
approved these changes
Dec 9, 2022
deepfire
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
4 times, most recently
from
39b1134 to
58569f8
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Dec 13, 2022
4667: tx-generator: add capability for PlutusV2 scripts r=deepfire a=mgmeier **NB**: This branch is rebased on `jj/update-ledger`, so it should only be merged on top of that. (_EDIT_: good to go ✅ ) This PR adds PlutusV2 capability to `bench/tx-generator` and prepares it to use the new SECP built-ins. * ✅ -- The generator can now handle PlutusV2 * ✅ -- Flake input bump for `plutus-apps`, to include latest SECP scripts for benchmarking * ✅ -- Script redeemers are now parametrizable in the generator, instead of hard-coded * ✅ -- workbench integration Additionally, workbench profiles `plutus-secp-ecdsa` and `plutus-secp-schnorr` have been defined. Those provide a benchmarking auto-loop script w/ a fitting redeemer targeted to use the respective SECP built-in. In this PR, the cost model used is the one for protocol version 8.0 from `preview`. Co-authored-by: Michael Karg <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
|
Timed out. |
deepfire
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
from
6d82d5e to
fd0f479
Compare
|
Very nice; this change enables consistently (and permamently) maintaining sets of protocol parameters and Plutus cost models. A great foundation for encoding a matrix of eras and protocol versions in workbench profiles. |
mgmeier
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
from
a4e80aa to
33f9f73
Compare
deepfire
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
2 times, most recently
from
33263ed to
319fef3
Compare
deepfire
force-pushed
the
mkarg/tx-generator-plutus-v2-update-ledger
branch
from
319fef3 to
f431387
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
4667: tx-generator: add capability for PlutusV2 scripts r=deepfire a=mgmeier **NB**: This branch is rebased on `jj/update-ledger`, so it should only be merged on top of that. (_EDIT_: good to go ✅ ) This PR adds PlutusV2 capability to `bench/tx-generator` and prepares it to use the new SECP built-ins. * ✅ -- The generator can now handle PlutusV2 * ✅ -- Flake input bump for `plutus-apps`, to include latest SECP scripts for benchmarking * ✅ -- Script redeemers are now parametrizable in the generator, instead of hard-coded * ✅ -- workbench integration Additionally, workbench profiles `plutus-secp-ecdsa` and `plutus-secp-schnorr` have been defined. Those provide a benchmarking auto-loop script w/ a fitting redeemer targeted to use the respective SECP built-in. In this PR, the cost model used is the one for protocol version 8.0 from `preview`. Co-authored-by: Michael Karg <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
|
Build failed: |
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Jan 10, 2023
4667: tx-generator: add capability for PlutusV2 scripts r=deepfire a=mgmeier **NB**: This branch is rebased on `jj/update-ledger`, so it should only be merged on top of that. (_EDIT_: good to go ✅ ) This PR adds PlutusV2 capability to `bench/tx-generator` and prepares it to use the new SECP built-ins. * ✅ -- The generator can now handle PlutusV2 * ✅ -- Flake input bump for `plutus-apps`, to include latest SECP scripts for benchmarking * ✅ -- Script redeemers are now parametrizable in the generator, instead of hard-coded * ✅ -- workbench integration Additionally, workbench profiles `plutus-secp-ecdsa` and `plutus-secp-schnorr` have been defined. Those provide a benchmarking auto-loop script w/ a fitting redeemer targeted to use the respective SECP built-in. In this PR, the cost model used is the one for protocol version 8.0 from `preview`. Co-authored-by: Michael Karg <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
|
Build failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: This branch is rebased on
jj/update-ledger, so it should only be merged on top of that. (EDIT: good to go ✅ )This PR adds PlutusV2 capability to
bench/tx-generatorand prepares it to use the new SECP built-ins.plutus-apps, to include latest SECP scripts for benchmarkingAdditionally, workbench profiles
plutus-secp-ecdsaandplutus-secp-schnorrhave been defined. Those provide a benchmarking auto-loop script w/ a fitting redeemer targeted to use the respective SECP built-in.In this PR, the cost model used is the one for protocol version 8.0 from
preview.