-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cardano governance documentation #4719
Conversation
1cb1b32
to
d6acaa3
Compare
d6acaa3
to
82f5f03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @CarlosLopezDeLara. Just a couple of comments/changes
|
||
The procedure is as follows: | ||
|
||
![](../reference/images/upshelley.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Twice in your image you say the update proposal is registered. Should the first instance say the update proposal is submitted and the "registered" after a quorum is reached? I haven't looked at the spec to check this but I noticed the use of "registered" twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update proposals can be registered earlier than 6k/f slots to the end of the epoch, or later. The image tries to show the behavior on both scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure but its not clear in the diagram. Preceding with "If the update proposal is registered here" would be clearer as right now is looks like two update proposals are being submitted. Also, I think the diagram is wrong. The blue and purple lines should be interchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the confusion might come from the term valid (from the spec). Valid does not mean "adopted". Valid means that if the update proposal is registered within the 6k/f slots to the end of the epoch window, its is valid to start accumulating votes during the next epoch.
Perhaps I can split this in two diagrams, one for each case 1) earlier than 6k/f 2) later than 6k/f
a72f9f3
to
b38186e
Compare
5838c1f
to
9b49e31
Compare
Update cardano-governance.md Update cardano-governance.md Fix typos. Update cardano-governance.md use term Global constant. Cardano governance doc This article describes the update proposal mechanism for Byron and Shelley+ eras. Demonstrates how to use the CLI to create update proposals for any era. Content review, some editing tweaks cardano governance update doc * Replace images to mention epoch length = 10k/f * Mention CIP-59 Update cardano-governance.md * Include re-delegation workflow * Section for genesis and delegate keys operations
4827e78
to
9b401a9
Compare
This article describes the update proposal mechanism for Byron and Shelley+ eras. Demonstrates how to use the CLI to create update proposals for any era.