Take all dependencies from Hackage or CHaP #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
requested review from
Jimbo4350,
newhoggy,
a team,
coot,
deepfire,
jutaro,
mgmeier,
fmaste,
cleverca22,
dcoutts,
JaredCorduan and
CarlosLopezDeLara
as code owners
erikd
force-pushed
the
erikd/chap
branch
2 times, most recently
from
e9d922d to
db3cd37
Compare
|
Needs rebase, and seems like there is a Conway related configuration error that's failing the tests. |
erikd
force-pushed
the
erikd/chap
branch
3 times, most recently
from
d6aa0e2 to
9a91794
Compare
|
This PR needs #4871 to be merged first to support CHaP revisions :-/ |
erikd
force-pushed
the
erikd/chap
branch
8 times, most recently
from
e249427 to
524beff
Compare
erikd
force-pushed
the
erikd/chap
branch
2 times, most recently
from
b6944e0 to
a1e7039
Compare
erikd
commented
Mar 9, 2023
| @@ -66,7 +66,8 @@ import Data.Aeson.Types (Parser) | |||
| import Data.Bifunctor | |||
| import Data.ByteArray (ByteArrayAccess) | |||
| import qualified Data.ByteArray | |||
| import Data.ByteString as BS | |||
newhoggy
reviewed
Mar 9, 2023
This also updates the version of `ledger` for repliminary support for the Conway era. The `network` and `consensus` dependencies are also updated.
newhoggy
approved these changes
Mar 9, 2023
newhoggy
changed the title
Jimbo4350
reviewed
Mar 10, 2023
| where | ||
| reconcile | ||
| reconcileBabbage |
Jimbo4350
reviewed
Mar 10, 2023
| -- version that this node will declare that it understands, when it | ||
| -- is in the Babbage era. Since Babbage is currently the last known | ||
| -- protocol version then this is also the Babbage protocol version. | ||
| Praos.conwayProtVer = ProtVer 9 0, |
There was a problem hiding this comment.
Shouldn't we be hiding this behind the TestEnableDevelopmentHardForkEras flag: e424031#diff-8c649864fe4b96d142cfd4c2bb9e32a9510fe737c6ad4e13e04b585ee15a6b74R210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.