stakeKey registration stake.skey witness not needed #4975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
gitmachtl/patch-4
branch
from
b4f862f to
8ab5e10
Compare
olgahryniuk
reviewed
Mar 13, 2023
Jimbo4350
reviewed
Mar 13, 2023
There was a problem hiding this comment.
Can we merge the commits? Also I'll approve after @olgahryniuk 's comment is addressed
newhoggy
force-pushed
the
gitmachtl/patch-4
branch
from
8ab5e10 to
0ff11f5
Compare
Since the start of Shelley we sign a stakeKey registration also with the stake.skey. Turnes out, this is wrong and not needed at all. 😱 According to https://hydra.iohk.io/build/6752481/download/1/delegation_design_spec.pdf Chapter 3.3: "We do not require a witness to register a stake address (besides, of course, any witnesses needed for the transaction that is used to post the certificate)." So only the certificate is needed and the witness for the payment of course. Add an explanation for why we only need 1 witness
newhoggy
force-pushed
the
gitmachtl/patch-4
branch
from
0ff11f5 to
eb6148d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For merging #3744