Script data serialisation #5002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/scriptDataSerialisation
branch
from
12f7306 to
bb656f6
Compare
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/scriptDataSerialisation
branch
2 times, most recently
from
c3a116e to
f5d1992
Compare
newhoggy
force-pushed
the
newhoggy/scriptDataSerialisation
branch
from
f5d1992 to
9b7c9bb
Compare
Jimbo4350
approved these changes
Mar 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
using detailed schema.
for `ScriptDataNumber` constructor including numbers outside `maxBound @Word64`.
newhoggy
force-pushed
the
newhoggy/scriptDataSerialisation
branch
from
9b7c9bb to
9b8e749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits
genIntegerintogenIntegerandgenConstructorIntegerso they they can have different ranges allowinggenIntegerto return negative values.Replaces #3860